Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): add greeting workflow for new issues and PRs. #128

Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat(workflows): add greeting workflow for new issues and PRs. #128

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a933952
feat(workflows): add greeting workflow for new issues and PRs.
K-dash Aug 18, 2024
4292a14
Update .github/workflows/greeting.yml
K-dash Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/greeting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Greetings

on:
pull_request_target:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 issue (security): Be cautious when using 'pull_request_target' event

The 'pull_request_target' event can be a security risk if not handled carefully, as it runs workflows with repository secrets on PRs from forks. Ensure that this workflow doesn't execute any untrusted code from the PR.

types:
- opened
issues:
types:
- opened

jobs:
greeting:
runs-on: ubuntu-latest
if: ${{ github.actor != 'all-contributors[bot]' && github.actor != 'ryansurf' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Consider using a more scalable approach for actor exclusions

The current hardcoded list of excluded actors might become difficult to maintain as it grows. Consider using a separate configuration file or a more dynamic approach for managing excluded users.

Suggested change
if: ${{ github.actor != 'all-contributors[bot]' && github.actor != 'ryansurf' }}
if: ${{ !contains(fromJson('["all-contributors[bot]", "ryansurf"]'), github.actor) }}

permissions:
issues: write
pull-requests: write
steps:
- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: "👋 Hi! Thanks for opening your first issue! 🎉 We're excited to see your contribution. If you find this project interesting or helpful, we'd be thrilled if you could give it a star ⭐ Your support means a lot to us! 😊"
pr-message: "👋 Hi! Thanks for submitting your first pull request! 🎉 We really appreciate your effort to improve this project. If you're enjoying your experience here and find the project interesting, we'd be over the moon if you could give it a star ⭐ It helps us grow and motivates us to keep improving! 🚀"
K-dash marked this conversation as resolved.
Show resolved Hide resolved
Loading