Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logo! #131

Merged
merged 1 commit into from
Aug 20, 2024
Merged

New logo! #131

merged 1 commit into from
Aug 20, 2024

Conversation

ryansurf
Copy link
Owner

@ryansurf ryansurf commented Aug 20, 2024

General:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code:

  1. Does your submission pass tests?
  2. Have you run the linter/formatter on your code locally before submission?
  3. Have you updated the documentation/README to reflect your changes, as applicable?
  4. Have you added an explanation of what your changes do?
  5. Have you written new tests for your changes, as applicable?

New logo for the project!

Summary by Sourcery

Update the project logo in the README file, replacing the old image with a new one and modifying the HTML structure for improved presentation.

Documentation:

  • Update the README to include a new project logo, replacing the previous image with a new one and adjusting the HTML for better alignment and display.

Copy link
Contributor

sourcery-ai bot commented Aug 20, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new logo for the project. The changes are implemented by updating the README.md file to replace the existing wave image with a new, larger CLI-surf logo image. The implementation involves modifying the HTML structure and styling of the image display in the README.

File-Level Changes

Files Changes
README.md Replaced the existing wave image with a new CLI-surf logo
README.md Modified the HTML structure from a paragraph tag to a div for better centering
README.md Updated the image source path to point to the new logo file
README.md Added inline CSS styling to control the logo's maximum dimensions and maintain aspect ratio

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@ryansurf ryansurf merged commit 4a22681 into main Aug 20, 2024
9 checks passed
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ryansurf - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more context about why this logo change is being made. Is it part of a larger rebranding effort?
  • Consider moving the inline styles to a separate CSS file or at least to a <style> tag for better maintainability.
  • Please fill out the pull request template completely to ensure all necessary checks have been performed.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant