Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccs fix #134

Merged
merged 1 commit into from
Aug 20, 2024
Merged

ccs fix #134

merged 1 commit into from
Aug 20, 2024

Conversation

ryansurf
Copy link
Owner

@ryansurf ryansurf commented Aug 20, 2024

General:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code:

  1. Does your submission pass tests?
  2. Have you run the linter/formatter on your code locally before submission?
  3. Have you updated the documentation/README to reflect your changes, as applicable?
  4. Have you added an explanation of what your changes do?
  5. Have you written new tests for your changes, as applicable?

Summary by Sourcery

Update the README.md to adjust the logo image dimensions for better display consistency.

Documentation:

  • Update the README.md to change the logo image size from a maximum height of 200px to a fixed width of 550px.

Copy link
Contributor

sourcery-ai bot commented Aug 20, 2024

Reviewer's Guide by Sourcery

This pull request makes a minor change to the README.md file, adjusting the display of the cli-surf logo image. The change replaces the style attribute with a width attribute, potentially improving the image's consistency across different viewing platforms.

File-Level Changes

Files Changes
README.md Modified the image tag for the cli-surf logo, replacing the style attribute with a width attribute

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@ryansurf ryansurf merged commit 1a866f5 into main Aug 20, 2024
9 checks passed
@ryansurf ryansurf deleted the logo branch August 20, 2024 19:41
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ryansurf - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -4,7 +4,7 @@
![GitHub last commit](https://img.shields.io/github/last-commit/ryansurf/cli-surf)

<p align="center">
<img src="./images/cli-surf_logo.png" style="max-height: 200px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (documentation): Consider using responsive image sizing

While setting a fixed width works, you might want to consider using a responsive approach to ensure the image looks good on various screen sizes. For example, you could use a percentage width or max-width. Good job on removing the inline style attribute!

Suggested change
<img src="./images/cli-surf_logo.png" style="max-height: 200px;">
<img src="./images/cli-surf_logo.png" style="max-width: 100%; width: 550px;">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant