-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the streamlit with updated dictionary keys #136
Conversation
Reviewer's Guide by SourceryThis pull request updates the streamlit_helper.py file to reflect changes in the forecast dictionary keys. The modifications ensure that the correct keys are used when accessing data from the report_dict, preventing errors when querying surf reports on Streamlit. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi! Thanks for submitting your first pull request!
• We appreciate your effort to improve this project.
• If you're enjoying your experience, please consider giving us a star ⭐
• It helps us grow and motivates us to keep improving! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @balugans - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
@balugans Nice work! Looks good to me 👍 If you'd like to create an issue for the missing streamlit-folium dependency, please feel free to do so! Thanks for you contribution |
@all-contributors please add @balugans for bug fix |
I've put up a pull request to add @balugans! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sure will do. i will open the issue |
When querying a surf report on streamlit, we get error which is because of the change in the forecast keys and streamlit_helper not reflecting the changes.
The code ensures the streamlit_helper keys match the new forecast keys.
Summary by Sourcery
Update streamlit_helper to align with new forecast dictionary keys, fixing errors in surf report queries.
Bug Fixes: