Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: remove args= parameter #14

Merged
merged 1 commit into from
May 26, 2024

Conversation

K-dash
Copy link
Collaborator

@K-dash K-dash commented May 26, 2024

@ryansurf

The changes are as follows:

  • Update server.py to use the new query_to_args_list function from helper.py instead of the parse_qs function
    • The query_to_args_list function is a simple function that stores a string as a list
    • The previously used parse_qs function converts query parameters into a dictionary format. Since the purpose of this change is to deprecate args= and store the single string specified in the query parameters as a list, the parse_qs function is no longer used.
  • Add test code for the query_to_args_list function

Also, I believe that the README.md file needs to be updated to reflect these changes, but before proceeding with that, could you please review the changes and confirm if there are any issues with the current implementation?

Fixes #7

@K-dash K-dash changed the title change: Deprecate args= parameter Change: Deprecate args= parameter May 26, 2024
@K-dash K-dash changed the title Change: Deprecate args= parameter Change: remove args= parameter May 26, 2024
@ryansurf ryansurf merged commit f355e89 into ryansurf:main May 26, 2024
2 checks passed
@ryansurf
Copy link
Owner

@K-dash nice, this looks great! Works on my end, nice tests too. Thank you! Merging now

@K-dash
Copy link
Collaborator Author

K-dash commented May 26, 2024

@ryansurf
Thank you for accepting my pull request!

Since we no longer use args=, the README.md file should need to be updated. Is it necessary for me to make those changes, or do you prefer to handle the README.md update yourself?

@K-dash K-dash deleted the feature/remove-args-prefix branch May 26, 2024 08:50
@K-dash
Copy link
Collaborator Author

K-dash commented May 26, 2024

Oh, there's also the GIF image that needs to be updated, so it might be better for you to handle it...

@ryansurf
Copy link
Owner

No need to change the readme, unless you'd like to. I'll get to it at some point tomorrow, either way works👍

Repository owner deleted a comment from allcontributors bot Aug 7, 2024
@ryansurf
Copy link
Owner

ryansurf commented Aug 7, 2024

@all-contributors please add @K-dash for code and documentation

Copy link
Contributor

@ryansurf

We had trouble processing your request. Please try again later.

@K-dash
Copy link
Collaborator Author

K-dash commented Aug 7, 2024

@all-contributors please add @K-dash for code

Copy link
Contributor

@K-dash

We had trouble processing your request. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make cli args prettier
2 participants