Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix for running streamlit as module missing error: streamlit-folium #140

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

balugans
Copy link
Contributor

General:

  • [ *] Have you followed the guidelines in our Contributing document?
  • [* ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code:

  1. [ *] Does your submission pass tests?
  2. [ *] Have you run the linter/formatter on your code locally before submission?
  3. Have you updated the documentation/README to reflect your changes, as applicable?
  4. Have you added an explanation of what your changes do?
  5. Have you written new tests for your changes, as applicable?

Running streamlit run src/dev_dreamlit.py and i get following error: ModuleNotFoundError: No module named 'streamlit-folium'.

Solution will be add the package streamlit-folium' to pyproject.toml

balugans and others added 3 commits August 21, 2024 12:09
merging forked version to latest
merge to forked branch all the newest changes
without streamlit-folium, there is error when running streamlit. This fix ensures streamlit-folium package is installed by adding it to pyproject.toml file
Copy link
Contributor

sourcery-ai bot commented Aug 21, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @balugans - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@ryansurf ryansurf merged commit e2e4ba0 into ryansurf:main Aug 21, 2024
5 checks passed
@ryansurf
Copy link
Owner

Looks great! Good job and thank you for fixing that bug

@ryansurf
Copy link
Owner

#139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants