Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python3.10-slim to decrease docker image size #142

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

chengjackjelly
Copy link
Contributor

I used python3.10-slim as the base docker image according to #113 .
I also notice #53 and found python-slim currently has vulnerabilities. That's the reason I choose python3.10-slim.
The current docker image decreased from 1.9GB to 1.02GB.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi! Thanks for submitting your first pull request!
• We appreciate your effort to improve this project.
• If you're enjoying your experience, please consider giving us a star ⭐
• It helps us grow and motivates us to keep improving! 🚀

@ryansurf
Copy link
Owner

@chengjackjelly sorry for the delay. 1.9 to 1.02 GB is huge. Good work, merging now

@ryansurf
Copy link
Owner

@all-contributors please add @chengjackjelly for infra

Copy link
Contributor

@ryansurf

I've put up a pull request to add @chengjackjelly! 🎉

@ryansurf ryansurf merged commit b966508 into ryansurf:main Sep 17, 2024
4 checks passed
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants