-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Poetry and docker compose #34
Introduce Poetry and docker compose #34
Conversation
- Add pyproject.toml and poetry.lock files for managing dependencies with Poetry - Remove requirements.txt as it is no longer needed due to Poetry integration - Update CI configuration files to work with Poetry instead of requirements.txt
- Update import statements in files under the src directory to use consistent paths - Poetry's introduction allows for better recognition of the project root path - Simplify and standardize import paths throughout the codebase
- Install Poetry within the Docker container - Add docker-compose.yml file to simplify application setup and development - Allow users to easily start the application without installing Poetry locally
Tested the changes on my local, everything works! The relative import issue was quite annoying, thank you for getting on that. The makefile you've created is perfect, everything is so simple to get up and going now. By this: The documentation you wrote is great, I used it when testing the changes on my local and it went smoothly. You've been doing some great work, thank you all the changes you've made. I wouldn't have thought of most of these things on my own 😂, I appreciate it! |
@ryansurf
Sorry, my explanation was a bit lacking. When it comes to developing with Docker Compose, all the development tools (like You might already be familiar with Remote Containers, but if you haven't tried it out yet, I totally recommend giving it a spin :) |
I see, I was not familiar with remote containers. Might be the move honestly, I started messing around with Docker a few months ago and haven't looked back. Thanks for explaining |
@ryansurf
Please check the PR for #32 first!
I've introduced Poetry:)
ae931c6
And the relative import thing I mentioned here has been resolved.
06e36b3
I also thought I'd recommend using Docker to launch it for users who don't want to use Poetry, and I've installed Docker Compose to make it easy to launch containers!
8d2efaf
Docker Compose allows you to develop with it, so eventually you may want to consolidate to containers.
Finally, the usage of Poetry and Docker Compose is reflected in README.md and CONTRIBUTING.md
d62a73a
I have checked that it works fine with what is written, but just to be sure, please check it in your environment as well!
Sorry for the amount of changes...