Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates! #38

Merged
merged 5 commits into from
Jun 2, 2024
Merged

Documentation updates! #38

merged 5 commits into from
Jun 2, 2024

Conversation

ryansurf
Copy link
Owner

@ryansurf ryansurf commented Jun 1, 2024

@K-dash

This PR makes changes to the documentation.

The following changes have been made:

  • The addition of the cheet_sheet.md file. This list typical commands that I run on the daily, and may be helpful for someone who is learning Git/the codebase
  • The addition of a Discord widget and a widget of the repo in index.md
  • Updated project structure in structure,md
  • Test doc update, including how to run make test and a screenshot of the coverage report
  • Added the new cheet_sheet.md to the mkdocs.yml file

I sent you an invite to be a collaborator, so I think you should be able to merge this PR. Let me know if you have any issues!

Copy link
Contributor

github-actions bot commented Jun 1, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src
   __init__.py00100% 
   api.py86693%30, 48, 70–71, 103–104
   art.py9367%24–25, 37
   cli.py23483%34, 50–51, 55
   gpt.py10640%16–21, 32–45
   helper.py1435264%50, 52, 54, 56, 58, 60, 62, 64, 66, 68, 70, 81, 92–96, 129–137, 149, 162–163, 181–183, 193, 195–196, 218–219, 256–266, 273–281
   send_email.py24240%5–48
   server.py41410%5–82
   settings.py220100% 
TOTAL35813662% 

Tests Skipped Failures Errors Time
9 0 💤 0 ❌ 0 🔥 12.503s ⏱️

Copy link
Collaborator

@K-dash K-dash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryansurf
I have reviewed the changes! Please take a look :)

│ ├── helper.py
│ ├── __init__.py
│ ├── __pycache__
│ ├── send_email.py
│ ├── server.py
│ ├── settings.py
│ ├── static
│ └── templates
├── start_venv.sh
Copy link
Collaborator

@K-dash K-dash Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the introduction of Poetry, I think start_venv.sh is no longer being used, so it might be okay to delete it!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's not necessary now, if the number of project files increases in the future, modifying this file could become a hassle. So, ex.g it might be a good idea to add a simple script to pre-commit that automatically retrieves and reflects the directory structure :)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the introduction of Poetry, I think start_venv.sh is no longer being used, so it might be okay to delete it!

Ah, forgot about that. Good call

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's not necessary now, if the number of project files increases in the future, modifying this file could become a hassle. So, ex.g it might be a good idea to add a simple script to pre-commit that automatically retrieves and reflects the directory structure :)

How did I not think of this...good idea. I'll work on getting that going

@@ -0,0 +1,52 @@
# Cheat Sheet!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@K-dash K-dash assigned K-dash and unassigned K-dash Jun 1, 2024
@ryansurf
Copy link
Owner Author

ryansurf commented Jun 2, 2024

@ryansurf

I have reviewed the changes! Please take a look :)

Thank you! I'll implement the changes you recommended and submit another PR

@K-dash
Copy link
Collaborator

K-dash commented Jun 2, 2024

Thank you! I'll implement the changes you recommended and submit another PR

You're welcome!

(Please ignore this if you already know 😃)
In the usual review process, you would create a fix commit in the same PR and push it to show that you have addressed the feedback. However, if the fix is expected to take time or can be handled later, the workflow is to create a separate PR.
In this case, I judged that the latter seems applicable, so for now, I will go ahead and merge this PR :)

@K-dash K-dash merged commit c44ceb8 into main Jun 2, 2024
7 checks passed
@K-dash K-dash deleted the documentation_updates branch June 2, 2024 02:00
@ryansurf
Copy link
Owner Author

ryansurf commented Jun 2, 2024

Thank you! I'll implement the changes you recommended and submit another PR

You're welcome!

(Please ignore this if you already know 😃) In the usual review process, you would create a fix commit in the same PR and push it to show that you have addressed the feedback. However, if the fix is expected to take time or can be handled later, the workflow is to create a separate PR. In this case, I judged that the latter seems applicable, so for now, I will go ahead and merge this PR :)

I see, thank you for the merge 😄

@ryansurf ryansurf mentioned this pull request Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants