-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates! #38
Conversation
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryansurf
I have reviewed the changes! Please take a look :)
│ ├── helper.py | ||
│ ├── __init__.py | ||
│ ├── __pycache__ | ||
│ ├── send_email.py | ||
│ ├── server.py | ||
│ ├── settings.py | ||
│ ├── static | ||
│ └── templates | ||
├── start_venv.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the introduction of Poetry, I think start_venv.sh
is no longer being used, so it might be okay to delete it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's not necessary now, if the number of project files increases in the future, modifying this file could become a hassle. So, ex.g it might be a good idea to add a simple script to pre-commit
that automatically retrieves and reflects the directory structure :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the introduction of Poetry, I think
start_venv.sh
is no longer being used, so it might be okay to delete it!
Ah, forgot about that. Good call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's not necessary now, if the number of project files increases in the future, modifying this file could become a hassle. So, ex.g it might be a good idea to add a simple script to
pre-commit
that automatically retrieves and reflects the directory structure :)
How did I not think of this...good idea. I'll work on getting that going
@@ -0,0 +1,52 @@ | |||
# Cheat Sheet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thank you! I'll implement the changes you recommended and submit another PR |
You're welcome! (Please ignore this if you already know 😃) |
I see, thank you for the merge 😄 |
@K-dash
This PR makes changes to the documentation.
The following changes have been made:
cheet_sheet.md
file. This list typical commands that I run on the daily, and may be helpful for someone who is learning Git/the codebaseindex.md
structure,md
make test
and a screenshot of the coverage reportcheet_sheet.md
to themkdocs.yml
fileI sent you an invite to be a collaborator, so I think you should be able to merge this PR. Let me know if you have any issues!