-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help.txt path update and new tests #62
Conversation
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed by! Please check:)
Hey @K-dash , thanks for the review. I like all of your suggestions, passing the environment variables as an argument makes more sense for testing purposes, let's implement these changes. I believe you can approve the changes you suggested? As the author of this PR I cannot. |
@ryansurf |
No problem 😃 Edit: Linter and formatter passed! Merging |
#61
help.txt
needed its path updated inserver.py
I also added new tests in tests/test_server.py, which make sure the Flask server is running and responds as intended (200 OK).
I turned the flask server into a function,
create_app()
, so we can spin up the server and perform tests on it with a function call.Let me know what you think! @K-dash