Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help.txt path update and new tests #62

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Help.txt path update and new tests #62

merged 5 commits into from
Jul 30, 2024

Conversation

ryansurf
Copy link
Owner

#61

help.txt needed its path updated in server.py

I also added new tests in tests/test_server.py, which make sure the Flask server is running and responds as intended (200 OK).

I turned the flask server into a function, create_app(), so we can spin up the server and perform tests on it with a function call.

Let me know what you think! @K-dash

@ryansurf ryansurf requested a review from K-dash July 25, 2024 16:55
Copy link
Contributor

github-actions bot commented Jul 25, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src
   __init__.py00100% 
   api.py106793%32–36, 54, 76–77, 109–110
   art.py9367%24–25, 37
   cli.py25388%26, 55–56
   dev_streamlit.py37370%1–86
   gpt.py10640%16–21, 32–45
   helper.py1596062%53, 55, 57, 59, 61, 63, 65, 67, 69, 71, 73, 75, 77, 79, 91, 102–106, 132, 134, 136, 145–155, 167, 180–181, 199–201, 211, 213–214, 237–238, 277–287, 294–302
   send_email.py24240%5–48
   server.py441077%53, 66–69, 83–87, 99–101
   settings.py220100% 
   streamlit_helper.py33330%5–90
TOTAL46918361% 

Tests Skipped Failures Errors Time
10 0 💤 0 ❌ 0 🔥 18.345s ⏱️

@ryansurf ryansurf mentioned this pull request Jul 25, 2024
Copy link
Collaborator

@K-dash K-dash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by! Please check:)

src/server.py Show resolved Hide resolved
src/server.py Outdated Show resolved Hide resolved
src/server.py Outdated Show resolved Hide resolved
tests/test_server.py Outdated Show resolved Hide resolved
@ryansurf
Copy link
Owner Author

Hey @K-dash , thanks for the review. I like all of your suggestions, passing the environment variables as an argument makes more sense for testing purposes, let's implement these changes.

I believe you can approve the changes you suggested? As the author of this PR I cannot.

@K-dash
Copy link
Collaborator

K-dash commented Jul 29, 2024

@ryansurf
I'm sorry, it seems there were issues with my proposal, as the Lint and Test are failing. 🙇
Could you please help me with the corrections?

@ryansurf
Copy link
Owner Author

ryansurf commented Jul 30, 2024

@ryansurf I'm sorry, it seems there were issues with my proposal, as the Lint and Test are failing. 🙇 Could you please help me with the corrections?

No problem 😃

Edit: Linter and formatter passed! Merging

@ryansurf ryansurf merged commit d3b910a into main Jul 30, 2024
6 checks passed
@ryansurf ryansurf deleted the help_path_update branch July 30, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants