Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api.py #64

Closed

Conversation

vaibhav-2703
Copy link
Contributor

Enhanced get_coordinates Function:

The function now checks if the provided location is valid. If the location is invalid, it prints a message and falls back to the default location. This ensures that the application does not break when an invalid location is provided.

Enhanced get_coordinates Function:

The function now checks if the provided location is valid. If the location is invalid, it prints a message and falls back to the default location.
This ensures that the application does not break when an invalid location is provided.
@K-dash
Copy link
Collaborator

K-dash commented Jul 27, 2024

@vaibhav-2703
Great job👏

However, Unfortunately, the Linter executed in CI is failing for the following reason.

image

As stated in CONTRIBUTING.md, you need to pass the static code analysis before submitting a PR. Please run the make install command to enable pre-commit hooks. This will ensure that static analysis is performed when you git commit.

Also, running make format will format your code according to PEP8 rules. Could you please make good use of this while working to ensure that the static analysis passes for the src/api.py file?

Did some changes to fix linter issues
Fixed issues to fix lint issues
@vaibhav-2703 vaibhav-2703 deleted the fix/handle-invalid-location branch July 27, 2024 06:46
@vaibhav-2703 vaibhav-2703 mentioned this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants