Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gpt fix #68

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Gpt fix #68

merged 5 commits into from
Jul 30, 2024

Conversation

ryansurf
Copy link
Owner

@ryansurf ryansurf commented Jul 29, 2024

#67

The free GPT that can be used if the user does not have an OpenAI API key was not working. The package had to be updated and the curl-cffi package was needed.

The dictionary key error is addressed in helper.py

I also am submitting this PR to see if Sourcery works

Summary by Sourcery

This pull request addresses a dictionary key error in the helper.py file by updating the key from 'Direction' to 'Swell Direction'.

  • Bug Fixes:
    • Fixed dictionary key error in helper.py by updating the key from 'Direction' to 'Swell Direction'.

Copy link
Contributor

sourcery-ai bot commented Jul 29, 2024

Reviewer's Guide by Sourcery

This pull request addresses an issue where the free GPT option was not working due to an outdated package. The curl-cffi package was added to resolve this. Additionally, a dictionary key error in helper.py was fixed by changing the key from 'Direction' to 'Swell Direction'.

File-Level Changes

Files Changes
src/helper.py Fixed a dictionary key error by updating the key from 'Direction' to 'Swell Direction' in the surf_summary function.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

github-actions bot commented Jul 29, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src
   __init__.py00100% 
   api.py106793%32–36, 54, 76–77, 109–110
   art.py9367%24–25, 37
   cli.py25580%26, 37, 55–56, 60
   dev_streamlit.py37370%1–86
   gpt.py10640%16–21, 32–45
   helper.py1596062%53, 55, 57, 59, 61, 63, 65, 67, 69, 71, 73, 75, 77, 79, 91, 102–106, 132, 134, 136, 145–155, 167, 180–181, 199–201, 211, 213–214, 237–238, 277–287, 294–302
   send_email.py24240%5–48
   server.py41410%5–82
   settings.py220100% 
   streamlit_helper.py33330%5–90
TOTAL46621654% 

Tests Skipped Failures Errors Time
9 0 💤 0 ❌ 0 🔥 16.737s ⏱️

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ryansurf - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR description mentions package updates and a new dependency, but these changes are not reflected in the diff. Could you please include these changes or update the description to match the actual modifications?
  • Consider using a more descriptive commit message that explains the specific change being made, rather than the generic 'Gpt fix'.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ryansurf
Copy link
Owner Author

@K-dash huzzah! Sourcery works!

Copy link
Collaborator

@K-dash K-dash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@ryansurf ryansurf merged commit c1790d7 into main Jul 30, 2024
7 checks passed
@ryansurf ryansurf deleted the gpt-fix branch July 30, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants