Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all contributors bot! #87

Merged
merged 2 commits into from
Aug 7, 2024
Merged

all contributors bot! #87

merged 2 commits into from
Aug 7, 2024

Conversation

ryansurf
Copy link
Owner

@ryansurf ryansurf commented Aug 6, 2024

@K-dash #83

Setup for the all-contributors bot to work

Added instructions for how to use the bot in CONTRIBUTING.md

.all-contributorsrc is the config file, specified here

Summary by Sourcery

Integrate the all-contributors bot to manage and display project contributors. Update README.md to include the all-contributors badge and placeholder for the contributors list.

Documentation:

  • Added instructions in CONTRIBUTING.md on how to use the all-contributors bot.

Chores:

  • Configured the all-contributors bot by adding .all-contributorsrc file.

@ryansurf ryansurf marked this pull request as ready for review August 6, 2024 20:06
Copy link
Contributor

sourcery-ai bot commented Aug 6, 2024

Reviewer's Guide by Sourcery

This pull request integrates the All Contributors bot into the project. The README.md file was updated to include a badge and placeholders for the contributors list, which will be managed by the bot. Additionally, CONTRIBUTING.md was updated with instructions on how to use the bot to add oneself to the contributors list.

File-Level Changes

Files Changes
README.md
CONTRIBUTING.md
Integrated the All Contributors bot by updating the README.md with a badge and placeholders for the contributors list, and added usage instructions in CONTRIBUTING.md.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ryansurf - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider keeping the existing contributor recognition alongside the new all-contributors setup until the new system is fully populated to ensure no contributors are temporarily unlisted.
  • The changes in README.md remove the current contributor display. Ensure that this transition doesn't inadvertently remove recognition for existing contributors.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

CONTRIBUTING.md Outdated
@@ -49,6 +49,14 @@ make output_coverage_docker
```
Additionally, when a PR is raised, pytest will be executed by the GitHub Actions CI.

## Adding youself to the contributors list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (documentation): Typo in 'youself'

The word 'youself' should be corrected to 'yourself'.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src
   __init__.py00100% 
   api.py119794%32–36, 54, 76–77, 109–110
   art.py9367%32–33, 36
   cli.py25388%26, 55–56
   dev_streamlit.py37370%1–86
   gpt.py10640%16–21, 32–45
   helper.py1797658%55, 57, 59, 61, 63, 65, 67, 69, 71, 73, 75, 77, 79, 81, 83, 85, 97, 108–112, 138, 140, 142, 144, 146, 158–180, 192, 205–206, 224–226, 236, 238–239, 262–263, 323–333, 340–348
   send_email.py24240%5–48
   server.py471079%55, 68–71, 87–91, 103–105
   settings.py220100% 
   streamlit_helper.py33330%5–90
TOTAL50519961% 

Tests Skipped Failures Errors Time
10 0 💤 0 ❌ 0 🔥 20.785s ⏱️

@K-dash
Copy link
Collaborator

K-dash commented Aug 6, 2024

LGTM🚀

As the next step,
I think we need to add all the contributors so far, can we call the bot on this PR?

@K-dash
Copy link
Collaborator

K-dash commented Aug 6, 2024

https://allcontributors.org/docs/en/emoji-key

I see that we can also set Contribution Types when we call the bot, should we add this setting as an operational rule?

@ryansurf
Copy link
Owner Author

ryansurf commented Aug 7, 2024

https://allcontributors.org/docs/en/emoji-key

I see that we can also set Contribution Types when we call the bot, should we add this setting as an operational rule?

I think the contribution setting is automatically applied, how do we make it optional? I might be a little silly right now but i don't see it

@ryansurf ryansurf merged commit 7714d28 into main Aug 7, 2024
7 of 9 checks passed
@K-dash K-dash deleted the all-contributors branch August 7, 2024 23:45
@K-dash
Copy link
Collaborator

K-dash commented Aug 7, 2024

@all-contributors please add @ryansurf for code and doc

Copy link
Contributor

@K-dash

I've put up a pull request to add @ryansurf! 🎉

@K-dash
Copy link
Collaborator

K-dash commented Aug 8, 2024

@ryansurf
The README.md is looking great! Thanks🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants