-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all contributors bot! #87
Conversation
Reviewer's Guide by SourceryThis pull request integrates the All Contributors bot into the project. The README.md file was updated to include a badge and placeholders for the contributors list, which will be managed by the bot. Additionally, CONTRIBUTING.md was updated with instructions on how to use the bot to add oneself to the contributors list. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ryansurf - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider keeping the existing contributor recognition alongside the new all-contributors setup until the new system is fully populated to ensure no contributors are temporarily unlisted.
- The changes in README.md remove the current contributor display. Ensure that this transition doesn't inadvertently remove recognition for existing contributors.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
CONTRIBUTING.md
Outdated
@@ -49,6 +49,14 @@ make output_coverage_docker | |||
``` | |||
Additionally, when a PR is raised, pytest will be executed by the GitHub Actions CI. | |||
|
|||
## Adding youself to the contributors list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Typo in 'youself'
The word 'youself' should be corrected to 'yourself'.
Coverage Report
|
LGTM🚀 As the next step, |
https://allcontributors.org/docs/en/emoji-key I see that we can also set Contribution Types when we call the bot, should we add this setting as an operational rule? |
I think the contribution setting is automatically applied, how do we make it optional? I might be a little silly right now but i don't see it |
@all-contributors please add @ryansurf for code and doc |
I've put up a pull request to add @ryansurf! 🎉 |
@ryansurf |
@K-dash #83
Setup for the all-contributors bot to work
Added instructions for how to use the bot in
CONTRIBUTING.md
.all-contributorsrc
is the config file, specified hereSummary by Sourcery
Integrate the all-contributors bot to manage and display project contributors. Update
README.md
to include the all-contributors badge and placeholder for the contributors list.Documentation:
CONTRIBUTING.md
on how to use the all-contributors bot.Chores:
.all-contributorsrc
file.