Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added detekt #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added detekt #111

wants to merge 2 commits into from

Conversation

UDarya
Copy link

@UDarya UDarya commented Jun 20, 2019

No description provided.

@gokulchandra
Copy link
Collaborator

gokulchandra commented Jun 27, 2019 •
edited
Loading

@rybalkinsd Do we require a static code analyser?

@rybalkinsd
Copy link
Owner

@UDarya many thanks for the proposal!

@gokulchandra I will check it right after 0.10.0 release. However, you're welcome to give suggestions/resolution about it.

We're using Codacy at the moment for static analysis, but probably direct use of detekt would be a better choice.

@gokulchandra
Copy link
Collaborator

I think it might be a good idea to add it to the project and make it a part of the build process.

@rybalkinsd Have you faced any issues with codacy as of yet? Do you see any pain points in Codacy that detekt could help with?

@rybalkinsd
Copy link
Owner

@UDarya @gokulchandra detekt 1.0 is out. would you mind to update PR?

@BoxResin
Copy link
Contributor

@UDarya You have to resolve conflicts too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxResin BoxResin BoxResin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UDarya @gokulchandra @rybalkinsd @BoxResin