Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: moshi integration #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rybalkinsd
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage     91.28%   91.28%           
  Complexity      127      127           
=========================================
  Files            44       44           
  Lines           413      413           
  Branches         52       52           
=========================================
  Hits            377      377           
  Misses            9        9           
  Partials         27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 518abf0...3402765. Read the comment docs.

@GolovPavel
Copy link
Contributor

GolovPavel commented May 30, 2020

Hi! Can you explain why did you integrate moshi in the project? I discovered that toType function already exists in kohttp-jackson gradle project, but uses jackson under the hood. What the reasons to use moshi instead of jackson?

@rybalkinsd
Copy link
Owner Author

rybalkinsd commented May 30, 2020

Hi! Can you explain why you integrate moshi in the project? I discovered that toType function already exists in kohttp-test gradle project, but uses jackson under the hood. What the reasons to use moshi instead of jackson?

Hey! Different projects use different (de)serialisation libraries and techniques, Moshi and Jackson are just two possible implementations. We don't want to limit our users with just one.
Moshi uses codegen-based approach for deserialisation and it's a preferable way for Android. However, Jackson is reflection based.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants