Handle double quotes, backslashes, CRs, NLs and tabs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de i did not understand in the rake file
As per best practice in lib development.
This is more or less a hack based on information gleaned from http://developer.apple.com/library/mac/#documentation/cocoa/conceptual/LoadingResources/Strings/Strings.html It only escapes NLs, CRs, tabs, double quotes and backslashes. Unicode escapes are not handled because I don't need them right now. In the case of unknown characters it does not remove the backslash which I did to be minimally invasive, however I did not confirm the actual behavior on Apple's side.
|
Thanks for contributing! I really appreciate it. |
| # http://developer.apple.com/library/mac/#documentation/cocoa/conceptual/LoadingResources/Strings/Strings.html | ||
| def unescape_value(string) | ||
| state = :normal | ||
| out = '' |
There was a problem hiding this comment.
I don't like the name "out". How about "output"?
|
It looks pretty good. I'm not going to merge this until the pr you branched off from is merged. |
|
This gem is no longer supported unfortunately. I don't have any suggestions on alternatives, sorry. Feel free to fork the repo, and continue its development. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a formal solution to all escaping, but it handles the common cases.