Rework code to not trigger false positive in gosec

rymdport · Nov 11, 2024 · 035bbb7 · 035bbb7
1 parent 8bd9b6e
commit 035bbb7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/settings/appearance/color.go b/settings/appearance/color.go
@@ -50,7 +50,7 @@ func ValueToColorScheme(value any) (ColorScheme, error) {
 	}
 
 	if result > 2 {
-		result = 0 // Unknown values should be treated as 0 (no preference).
+		return 0, nil // Unknown values should be treated as 0 (no preference).
 	}
 
 	return ColorScheme(result), nil

diff --git a/settings/appearance/contrast.go b/settings/appearance/contrast.go
@@ -30,7 +30,7 @@ func ValueToContrast(value any) (Contrast, error) {
 	}
 
 	if result > 1 {
-		result = 0 // Unknown values should be treated as 0 (no preference).
+		return 0, nil // Unknown values should be treated as 0 (no preference).
 	}
 
 	return Contrast(result), nil