Avoid potential integer overflow

rymdport · Nov 10, 2024 · c1ff5c7 · c1ff5c7
1 parent 9a32628
commit c1ff5c7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/settings/appearance/color.go b/settings/appearance/color.go
@@ -27,7 +27,7 @@ func GetColorScheme() (ColorScheme, error) {
 	}
 
 	result := value.(uint32)
-	if result > 2 {
+	if result > 2 || result > 255 {
 		result = 0 // Unknown values should be treated as 0 (no preference).
 	}
 

diff --git a/settings/appearance/contrast.go b/settings/appearance/contrast.go
@@ -18,7 +18,7 @@ func GetContrast() (Contrast, error) {
 	}
 
 	result := value.(uint32)
-	if result > 1 {
+	if result > 1 || result > 255 {
 		result = 0 // Unknown values should be treated as 0 (no preference).
 	}