Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SHA option #92

Closed
wants to merge 3 commits into from
Closed

Add SHA option #92

wants to merge 3 commits into from

Conversation

bewuethr
Copy link

@bewuethr bewuethr commented Aug 3, 2023

This adds an option to overwrite the commit SHA on which the release is created; by default, that's GITHUB_SHA, but for some events such as workflow_run, GITHUB_SHA might not be what we want.

Closes #77

PR Notes

  • Reviewed Checks: Verified output of Integration Tests
  • Have set labels for release level

@bewuethr
[PLAT-6085] Add SHA option (#1)
e800196 
This adds an option to overwrite the commit SHA on which the release is
created; by default, that's GITHUB_SHA, but for some events such as
workflow_run, GITHUB_SHA might not be what we want.

PLAT-6085
@bewuethr bewuethr mentioned this pull request Aug 3, 2023
Open
@bewuethr
Don't use empty SHA input (#2)
f2fbf56 
When the SHA input is empty, it's considered truthy, and we try to use
it; this PR checks for empty, and then falls back to "GITHUB_SHA"
instead.
@bewuethr
Copy link
Author

bewuethr commented Oct 1, 2024

Closing in favour of #101

@bewuethr bewuethr closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kripu77 Kripu77 Kripu77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request - Specify commit SHA as input
2 participants
@bewuethr @Kripu77