Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: empty upload_url #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: empty upload_url #94

wants to merge 2 commits into from

Conversation

dctrotz
Copy link

@dctrotz dctrotz commented Nov 8, 2023

PR Notes

  • Reviewed Checks: Verified output of Integration Tests
  • Have set labels for release level

@dctrotz
Fix to properly obtain upload_url
cc427d4 
This is based on a patch by @DasBen
@dctrotz
Get the upload_url from the release
20a10cd 
Capture api-response from create parameters and pass that to the output parameters to obtain the upload_url
@dctrotz
Copy link
Author

dctrotz commented Nov 8, 2023

This is based on a PR by @DasBen- I basically ignored all his whitespace changes and other non-essential changes and focused on the core of the issue. I don't see how the upload_url ever worked.

@chickenandpork
Copy link

Ran into the problem tonight. I'll switch to your fork until the PR merges.

Hey @rymndhng can you give it a look ?

@Jesse592
Copy link

LGTM, Also ran into this problem, switching to your fork @dctrotz fixed it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dctrotz @chickenandpork @Jesse592