Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: home page input form #279

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Jay-Karia
Copy link
Contributor

@Jay-Karia Jay-Karia commented Jul 21, 2024

Updates the input form on the home page.

Copy link

vercel bot commented Jul 21, 2024

@Jay-Karia is attempting to deploy a commit to the ryo-ma's Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a form to fetch GitHub trophies is functional but can be improved for readability and efficiency. Firstly, the script tag appears redundant as no script content is included; it can be removed. Additionally, ensuring the placeholder text in the input field matches the button text for consistency is recommended. Here is the revised version:

<form action="https://github-profile-trophy.vercel.app/" method="get">
  <label for="username">GitHub Username</label>
  <input type="text" name="username" id="username" placeholder="Ex. gabriel-logan" required>
  <button type="submit">Get Trophies</button>
</form>

This streamlined version improves readability and maintains functionality without unnecessary elements.

@Jay-Karia
Copy link
Contributor Author

Creating a form to fetch GitHub trophies is functional but can be improved for readability and efficiency. Firstly, the script tag appears redundant as no script content is included; it can be removed. Additionally, ensuring the placeholder text in the input field matches the button text for consistency is recommended. Here is the revised version:

<form action="https://github-profile-trophy.vercel.app/" method="get">
  <label for="username">GitHub Username</label>
  <input type="text" name="username" id="username" placeholder="Ex. gabriel-logan" required>
  <button type="submit">Get Trophies</button>
</form>

This streamlined version improves readability and maintains functionality without unnecessary elements.

Cool,
I'll update it.

@Jay-Karia Jay-Karia closed this Jul 24, 2024
@Jay-Karia Jay-Karia deleted the typo/trophies branch July 24, 2024 13:38
@Jay-Karia Jay-Karia restored the typo/trophies branch July 24, 2024 13:39
@Jay-Karia Jay-Karia reopened this Jul 24, 2024
@Jay-Karia Jay-Karia changed the title fix: typo in home page button fix: home page input form Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants