Make it work on Linux and language 0.1.091 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytc
reviewed
Jan 26, 2025
| @@ -870,7 +876,7 @@ Result_Status :: enum { | |||
| FAILURE; | |||
| } | |||
|
|
|||
| Socket :: #type SOCKET; | |||
| //Socket :: #type SOCKET; | |||
There was a problem hiding this comment.
I saw that this is already defined in the Socket module, so I think it can go ahead and be delete.
Suggested change
| //Socket :: #type SOCKET; |
|
|
||
| return -1, error_no; | ||
| } | ||
|
|
||
| if msg_header.msg_flags & MSG_TRUNC return -1; | ||
| //if msg_header.msg_flags & MSG_TRUNC return -1; @TODO |
|
|
||
| if poll_count == 0 then return .NONE; | ||
| if poll_socket.revents & POLLOUT then condition.* |= .WAIT_SEND; | ||
| if pollSocket.revents & POLLIN then condition.* |= .WAIT_RECEIVE; | ||
| //if poll_socket.revents & POLLOUT then condition.* |= .END; |
There was a problem hiding this comment.
If this isn't needed then I think it can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #12 atleast for version 0.1.091.
I've been running it this way on a vps for 1 week without crashes and leaking memory, but I am not sure if this implementation is "the correct" way of doing it.