Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise InvalidTokenException on invalid token #1874

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

rytilahti
Copy link
Owner

Invalid checksum raises now a more specialized InvalidTokenException. This will allow downstreams to request the user to check the token.

This will allow downstreams to request the user to check the token
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (36b4025) 81.40% compared to head (3ea06cc) 81.40%.
Report is 2 commits behind head on master.

Files Patch % Lines
miio/miioprotocol.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1874   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files         193      193           
  Lines       18563    18563           
  Branches     4025     4024    -1     
=======================================
+ Hits        15111    15112    +1     
+ Misses       3171     3170    -1     
  Partials      281      281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti merged commit 5241bcc into master Dec 5, 2023
23 of 24 checks passed
@rytilahti rytilahti deleted the feat/invalid_token_exception branch December 5, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant