-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes to roborockvacuum #1916
Merged
rytilahti
merged 10 commits into
master
from
roborock/fix/descriptors_from_updatehelper
Mar 18, 2024
Merged
Various fixes to roborockvacuum #1916
rytilahti
merged 10 commits into
master
from
roborock/fix/descriptors_from_updatehelper
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1916 +/- ##
==========================================
- Coverage 81.43% 81.42% -0.02%
==========================================
Files 193 193
Lines 18604 18628 +24
Branches 4032 4041 +9
==========================================
+ Hits 15150 15167 +17
- Misses 3173 3179 +6
- Partials 281 282 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status()
response. This performs I/O during the initialization to find out which information is available. Alternative would be changingupdatehelper.py
to collect the descriptors from all embedded updates, unsure what's the best approach.Related to rytilahti/homeassistant-xiaomi-ng#1