Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to roborockvacuum #1916

Merged
merged 10 commits into from
Mar 18, 2024

Conversation

rytilahti
Copy link
Owner

  • Include descriptors from status() response. This performs I/O during the initialization to find out which information is available. Alternative would be changing updatehelper.py to collect the descriptors from all embedded updates, unsure what's the best approach.
  • Fix exposing vacuum state.
  • Expose fan speed presets.

Related to rytilahti/homeassistant-xiaomi-ng#1

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.42%. Comparing base (4083283) to head (8edabc1).

Files Patch % Lines
miio/integrations/roborock/vacuum/vacuum.py 16.66% 5 Missing ⚠️
miio/device.py 0.00% 1 Missing and 1 partial ⚠️
miio/descriptorcollection.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
- Coverage   81.43%   81.42%   -0.02%     
==========================================
  Files         193      193              
  Lines       18604    18628      +24     
  Branches     4032     4041       +9     
==========================================
+ Hits        15150    15167      +17     
- Misses       3173     3179       +6     
- Partials      281      282       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti merged commit 8230bd4 into master Mar 18, 2024
20 of 24 checks passed
@rytilahti rytilahti deleted the roborock/fix/descriptors_from_updatehelper branch March 18, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant