Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev. by Serge X Cohen #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

serge-cohen
Copy link

Hello Simon,

I'd really like the few additions I have worked on for OpenCL package to end up in CRAN. We discussed in the past and it seemed the mean complexity was that my work was on a git outside of GitHub. I also noted you wanted (for very good reasons) that my proposed commits to be as atomic as possible and with focused objectives each of them.
I am proposing the these two first commits : here are what they are performing :

  1. https://github.com/s-u/OpenCL/tree/a7071085f3e3ea35cc2909c91190fa8d55657ebf is just adding some extra information to the oclInfo call on a device. In particular it gives access to some memory and image capabilities of the OpenCL device. There is also a way to set default platform/device (through defaults getOption("ocl.default.platform") and getOption("ocl.default.device").
  2. It handles in a better way the case that there is more than just one available platform on the coputer. In such case, oclDevice (without providing a platform) will scan all devices of all platforms instead of scanning only the devices of the first platform (which might be 'pocl', and as such would not have any GPU device).

I really hope you can accept these pull request. To my knowledge this should not break any of the existing code/API.

If this way to work is ok with you, and you find my proposal of sufficient quality, I'll go on adding support for OpenCL images.

Currently I have two other computation intensive package I can not push to CRAN because they rely on some of the extensions I have coded in OpenCL.

Cheers,

Serge.

Serge Cohen and others added 4 commits October 30, 2024 19:46
Now 
R CMD build OpenCL && R CMD check OpenCL_0.2-11.tar.gz

Is not reporting error… sorry, I should definitely have done those tests before the pull request.
@serge-cohen
Copy link
Author

Sorry Simon,

I should have checked before the commit and pull-request… there was a left over from the rebase conflict resolution. This is corrected in commit 1e17e8c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants