Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Simon,
I'd really like the few additions I have worked on for OpenCL package to end up in CRAN. We discussed in the past and it seemed the mean complexity was that my work was on a git outside of GitHub. I also noted you wanted (for very good reasons) that my proposed commits to be as atomic as possible and with focused objectives each of them.
I am proposing the these two first commits : here are what they are performing :
I really hope you can accept these pull request. To my knowledge this should not break any of the existing code/API.
If this way to work is ok with you, and you find my proposal of sufficient quality, I'll go on adding support for OpenCL images.
Currently I have two other computation intensive package I can not push to CRAN because they rely on some of the extensions I have coded in OpenCL.
Cheers,
Serge.