Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev deps #148

Merged
merged 8 commits into from
Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,23 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Pull & update submodules
run: |
git submodule update --init

- name: EMSDK Version
id: emsdk-version
run: |
echo "::set-output name=SHA::$(./submodules/emsdk/emsdk list | grep recommended | awk -F'[()]' '{print $2}')"
echo "EMSDK_SHA=$(./submodules/emsdk/emsdk list | grep recommended | awk -F'[()]' '{print $2}')" >> $GITHUB_ENV
- name: Cache EMSDK
id: cache-emsdk
uses: actions/cache@v3
with:
path: submodules/emsdk
key: ${{ runner.os }}-c-emsdk-${{ steps.emsdk-version.outputs.SHA }}
key: ${{ runner.os }}-d-emsdk-${{ env.EMSDK_SHA }}
restore-keys: |
${{ runner.os }}-c-emsdk-
${{ runner.os }}-d-emsdk-
- name: Update EMSDK
if: steps.cache-emsdk.outputs.cache-hit != 'true'
run: |
Expand All @@ -49,20 +49,12 @@ jobs:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Setup Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '18'

- name: Cache NPM Dependencies
id: cache-npm
uses: actions/cache@v3
with:
path: ~/.npm
key: ${{ runner.os }}-c-node-${{ hashFiles('package-lock.json') }}
restore-keys: |
${{ runner.os }}-c-node-
node-version: '20'
cache: 'npm'

- name: Install NPM Dependencies
run: |
Expand Down
43 changes: 11 additions & 32 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Deploy docs to Pages
on:
# Runs on pushes targeting the default branch
push:
branches: ["main"]
branches: ['main']

# Allows you to run this workflow manually from the Actions tab
workflow_dispatch:
Expand All @@ -16,7 +16,7 @@ permissions:

# Allow one concurrent deployment
concurrency:
group: "pages"
group: 'pages'
cancel-in-progress: true

jobs:
Expand All @@ -26,28 +26,14 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Detect package manager
id: detect-package-manager
run: |
if [ -f "${{ github.workspace }}/yarn.lock" ]; then
echo "manager=yarn" >> $GITHUB_OUTPUT
echo "command=install" >> $GITHUB_OUTPUT
echo "runner=yarn" >> $GITHUB_OUTPUT
exit 0
elif [ -f "${{ github.workspace }}/package.json" ]; then
echo "manager=npm" >> $GITHUB_OUTPUT
echo "command=ci" >> $GITHUB_OUTPUT
echo "runner=npm" >> $GITHUB_OUTPUT
exit 0
else
echo "Unable to determine packager manager"
exit 1
fi
- name: Setup Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: "18"
cache: ${{ steps.detect-package-manager.outputs.manager }}
node-version: '20'
cache: 'npm'
- name: Install NPM Dependencies
run: |
npm install
- name: Setup Pages
uses: actions/configure-pages@v3
with:
Expand All @@ -56,17 +42,10 @@ jobs:
#
# You may remove this line if you want to manage the configuration yourself.
static_site_generator: next
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- name: Install dependencies
run: ${{ steps.detect-package-manager.outputs.manager }} ${{ steps.detect-package-manager.outputs.command }}
- name: Custom Build with Node
run: ${{ steps.detect-package-manager.outputs.runner }} run docs
run: npm run docs
- name: Upload artifact
uses: actions/upload-pages-artifact@v1
uses: actions/upload-pages-artifact@v2
with:
path: ./docs

Expand All @@ -80,4 +59,4 @@ jobs:
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v1
uses: actions/deploy-pages@v2
16 changes: 16 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,22 @@
See [Microsoft's Change log](https://github.com/microsoft/SEAL/blob/master/CHANGES.md)
for more details on each SEAL version change.

## Version 5.1.2

Chore:

- Updated all dev dependencies
- Updated GHA runners to use Node v20 LTS (Iron)

Fix:

- Updated a test's return value that changed when using the latest emscripten SDK.

Breaking:

- Removed support for the pure JS build. Most modern JS environments use the
WASM variant and this particular build was incredibly slow and did not support memory over 2GB when invoking wasm2js

## Version 5.1.1

Feat:
Expand Down
2 changes: 1 addition & 1 deletion CITATION.cff
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors:
given-names: "Nick"
orcid: "https://orcid.org/0000-0001-7423-158X"
title: "node-seal, a Homomorphic Encryption library for TypeScript or JavaScript using Microsoft SEAL"
version: 5.1.1
version: 5.1.2
doi: 10.5281/zenodo.1234
date-released: 2022-03-19
url: "https://github.com/s0l0ist/node-seal"
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ npm run em:update # Updates the tag information
Finally, configure the Microsoft SEAL build settings:

```shell
npm run build # Will build the two MS-SEAL variants (allows, throws), supporting `node`, `web`, and `worker` emscripten environments
npm run build # Will build the two MS-SEAL variants (allows, throws), supporting `node`, `web`, and `worker` emscripten environments. Mac M1+ machines will need to install rosetta (`softwareupdate --install-rosetta`) for the closure compiler.
npm run test # Will run jest tests on the *.ts files
npm run coverage # Check coverage
npm run compile # Test compile before bundling, useful for debugging
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ ciphertexts. This is also the default import that is used.

The deep import link is structured like the following:

`node-seal / <throws|allows>_<wasm|js>_<node|web|worker>_<umd|es>`
`node-seal / <throws|allows>_wasm_<node|web|worker>_<umd|es>`

```javascript
// Always Pick a variant which throws on transparent ciphertexts unless you
Expand Down
10 changes: 0 additions & 10 deletions dev/js.html

This file was deleted.

Loading
Loading