Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: embed json certificate into pdf #241

Merged
merged 39 commits into from
Mar 1, 2024
Merged

Conversation

christophbuehler
Copy link
Contributor

@christophbuehler christophbuehler commented Feb 15, 2024

Description

TL;DR

generatePdf(
  certificate,
  {
-   inputType: 'json',
-   outputType: 'buffer',
+   attachCertificate: true,
+   a3Compliant: true,
  }
)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (a code change that neither fixes a bug nor adds a feature)
  • Dependencies update
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@christophbuehler christophbuehler linked an issue Feb 15, 2024 that may be closed by this pull request
@christophbuehler christophbuehler self-assigned this Feb 15, 2024
@christophbuehler christophbuehler added the enhancement New feature or request label Feb 15, 2024
Copy link
Contributor Author

@christophbuehler christophbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review completed.

@christophbuehler christophbuehler marked this pull request as ready for review February 15, 2024 22:27
Copy link

nx-cloud bot commented Feb 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a3592b7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

Copy link

github-actions bot commented Feb 15, 2024

Warnings
⚠️ ❗ Big PR (1)
Messages
📖 👍 You ticked most of the checkboxes!

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, please split each into separate PRs which will make them easier to review.

Generated by 🚫 dangerJS against a3592b7

packages/generate-pdf/src/index.ts Outdated Show resolved Hide resolved
packages/generate-pdf/src/attach-file-to-pdf.ts Outdated Show resolved Hide resolved
packages/generate-pdf/example_coa.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@christophbuehler christophbuehler added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Feb 23, 2024
This was linked to issues Feb 23, 2024
Copy link
Contributor Author

@christophbuehler christophbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced Lato with NotoSans, PDF A/3 compliance, cleanup

packages/generate-pdf/tsconfig.json Outdated Show resolved Hide resolved
packages/generate-pdf/src/pdf-a-3a/index.ts Outdated Show resolved Hide resolved
packages/generate-pdf/src/index.ts Outdated Show resolved Hide resolved
Copy link
Member

@eamon0989 eamon0989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

utils/create-pdf-certificate.ts Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 15%)

See analysis details on SonarCloud

@christophbuehler christophbuehler merged commit 7ffabb1 into main Mar 1, 2024
8 of 9 checks passed
@christophbuehler christophbuehler deleted the embed-json-into-pdf branch March 1, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: remove lato from pdf feat: ensure pdfs are in pdf/a-3a feat: embed JSON into PDF rendering
3 participants