New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KFParticle dEdx #3463

Open

aopatton wants to merge 4 commits into sPHENIX-Collaboration:master from aopatton:dEdx

+150 −9

Contributor

aopatton commented Mar 5, 2025

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work for users)
Requiring change in macros repository (Please provide links to the macros pull request in the last section)
I am a member of GitHub organization of sPHENIX Collaboration, EIC, or ECCE (contact Chris Pinkenburg to join)

What kind of change does this PR introduce? (Bug fix, feature, ...)

This adds dEdx for daughter branches to KFParticle's output

TODOs (if applicable)

Implementing dEdx selection in KFParticle's candidate selection could be useful in future for background reduction. Currently this just saves it to output to allow for selection in plotting

Links to other PRs in macros and calibration repositories (if applicable)

aopatton added 2 commits

March 5, 2025 10:10


          Added dEdx to KFParticle nTuple

0dfe62f


          Added check in dEdx calc to make sure cluster map and geometry is acc…

414d97e

…essible

osbornjd requested changes

View reviewed changes

Contributor

osbornjd left a comment

We have this dedx calculation function proliferating in our code. Can you add it here so that we have a centralized version of the calculation?


          Added dEdx calc to TrackAnalysisUtils

fad03cb

sphenix-jenkins-ci bot commented Mar 5, 2025

Build & test report

Report for commit 414d97e8dc403eb3d25777be358c07d6aca480b3:

builds and tests overall are SUCCESS.
Build with configuration of alma9.2-gcc-14.2.0 / clang is SUCCESS, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- Calorimeter QA: build is SUCCESS, 📊 trends
  - 📊 QA-calorimeter for e- at p_T=4GeV : combined Chi2/nDoF = 14.182 / 72, and combined p-Value = 1
  - 📊 QA-calorimeter for pi+ at p_T=30GeV : combined Chi2/nDoF = 46.0581 / 72, and combined p-Value = 0.992606
  - 📊 QA-calorimetric-jet for e- at p_T=4GeV : combined Chi2/nDoF = 28.6655 / 42, and combined p-Value = 0.941883
  - 📊 QA-calorimetric-jet for pi+ at p_T=30GeV : combined Chi2/nDoF = 9.21446 / 42, and combined p-Value = 1
- Tracking QA with Distortions: build is SUCCESS, 📊 trends
  - 📊 QA-distortions
- Tracking QA at low occupancy: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 56, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- Tracking QA for Pythia D0-jet: build is SUCCESS, 📊 trends
  - 📊 QA-Intt : combined Chi2/nDoF = -0 / 72, and combined p-Value = 1
  - 📊 QA-Micromegas : combined Chi2/nDoF = -0 / 20, and combined p-Value = 1
  - 📊 QA-Mvtx : combined Chi2/nDoF = -0 / 54, and combined p-Value = 1
  - 📊 QA-Tpc : combined Chi2/nDoF = 1.56946e-06 / 56, and combined p-Value = 1
  - 📊 QA-tracking : combined Chi2/nDoF = -0 / 50, and combined p-Value = 1
  - 📊 QA-vertexing : combined Chi2/nDoF = 30 / 112, and combined p-Value = 1
- system alma9.2-gcc-14.2.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_PRDFReconstruction.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of CaloProduction/Fun4All_Year2.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of StreamingProduction/Fun4All_Stream_Combiner.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: Valgrind test of TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C: build is SUCCESS, 📊valgrind report, trends 📊
- system alma9.2-gcc-14.2.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
- system alma9.2-gcc-14.2.0, build new: Valgrind test: build is SUCCESS, 📊valgrind report, trends 📊
Build with configuration of alma9.2-gcc-14.2.0 / scan is SUCCESS, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is SUCCESS, 📊Compiler report (full)/(new), build log
- Generating DST and readback: build is SUCCESS
- system gcc-12.1.0, build new: run the default sPHENIX macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default CaloProduction/Fun4All_Year2.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default StreamingProduction/Fun4All_Stream_Combiner.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the default TrackingProduction/Fun4All_TrkrHitSet_Unpacker.C macro: build is SUCCESS, output, trends 📊
- system gcc-12.1.0, build new: run the overlap check for sPHENIX macro: build is SUCCESS, output
clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration

sphenix-jenkins-ci bot commented Mar 6, 2025

Build & test report

Report for commit fad03cb252db7eebdc7cafed2546f0e219440775:

builds and tests overall are FAILURE.
Build with configuration of alma9.2-gcc-14.2.0 / clang is FAILURE, 📊clang report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / new is FAILURE, 📊Compiler report (full)/(new), build log
Build with configuration of alma9.2-gcc-14.2.0 / scan is FAILURE, 📊scan-build report (full)/(new), build log
Build with configuration of gcc-12.1.0 / new is FAILURE, 📊Compiler report (full)/(new), build log
clang-tidy is SUCCESS, 📊clang-tidy report (full)/(new)
cpp-check is SUCCESS, 📊cppcheck report (full)/(new)

Automatically generated by sPHENIX Jenkins continuous integration


          refactor out of trackbase_historic to avoid library dependency issues

8e4f588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet