Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added carousel slider in work experience and achievement section issues: #415 #435

Closed
wants to merge 9 commits into from

Conversation

S-codes14
Copy link

this is what @saadpasta said "We can add a Carousel slider in the work experience and Achievement & certificate section so that more experience and certificates can be added without just increasing the length of the portfolio. I found that if we add more achievements, the cards are increasing on the same page instead of the slider can do better for adding more than cards."
here

I tried to come up with a solution and it works

@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saadpasta/developer-folio/2udCYf4F9AdfqadcAw6dVQ6EHqzB
✅ Preview: https://developer-folio-git-fork-s-codes14-master-saadpasta.vercel.app

@S-codes14 S-codes14 changed the title Added carousel slider in work experience and achievement section #415 Added carousel slider in work experience and achievement section https://github.com/saadpasta/developerFolio/issues/415 Oct 12, 2021
@S-codes14 S-codes14 changed the title Added carousel slider in work experience and achievement section https://github.com/saadpasta/developerFolio/issues/415 Added carousel slider in work experience and achievement section issues: 415 Oct 12, 2021
@S-codes14 S-codes14 changed the title Added carousel slider in work experience and achievement section issues: 415 Added carousel slider in work experience and achievement section issues: #415 Oct 12, 2021
@S-codes14
Copy link
Author

S-codes14 commented Oct 14, 2021

@kartikcho @naveen521kk please review

@kartikcho
Copy link
Collaborator

kartikcho commented Oct 26, 2021

Sorry for the lack of clarity in the original issue and checking this PR out so late, it's been a busy couple of weeks.
Without digging into the code, I having a carousel that only adds a slider when the cards are more than 3 would be better than having a design that affects the original card layout. (Same for the achievements section)

Something like this (only having controls when the cards are more than 3 and they move horizontally). Also keep in mind that they should be touch supported.

image

cc: @naveen521kk (would like to hear what you think)

@kartikcho
Copy link
Collaborator

Also, if it's possible without an external dependency or through CSS only, that would be best.

@naveen521kk
Copy link
Collaborator

having a carousel that only adds a slider when the cards are more than 3 would be better than having a design that affects the original card layout. (Same for the achievements section)

👍

Sorry for the delayed response, had a super busy week. I would like to have a slider only when there are more than 3 cards, probably without breaking the previous design.

@saadpasta
Copy link
Owner

Closing this PR due to no response

@saadpasta saadpasta closed this Mar 3, 2022
@S-codes14
Copy link
Author

I was going to respond it is just that you guys are unclear on what type of carousel you want

@sadapasta
Copy link
Contributor

I don't think so there should be carousel for this maybe better to fix this in just one or 2 grid maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants