-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added carousel slider in work experience and achievement section issues: #415 #435
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/saadpasta/developer-folio/2udCYf4F9AdfqadcAw6dVQ6EHqzB |
for more information, see https://pre-commit.ci
@kartikcho @naveen521kk please review |
Sorry for the lack of clarity in the original issue and checking this PR out so late, it's been a busy couple of weeks. Something like this (only having controls when the cards are more than 3 and they move horizontally). Also keep in mind that they should be touch supported. cc: @naveen521kk (would like to hear what you think) |
Also, if it's possible without an external dependency or through CSS only, that would be best. |
👍 Sorry for the delayed response, had a super busy week. I would like to have a slider only when there are more than 3 cards, probably without breaking the previous design. |
Closing this PR due to no response |
I was going to respond it is just that you guys are unclear on what type of carousel you want |
I don't think so there should be carousel for this maybe better to fix this in just one or 2 grid maybe |
this is what @saadpasta said "We can add a Carousel slider in the work experience and Achievement & certificate section so that more experience and certificates can be added without just increasing the length of the portfolio. I found that if we add more achievements, the cards are increasing on the same page instead of the slider can do better for adding more than cards."
here
I tried to come up with a solution and it works