feat: (section-list): Allow user to drag and drop to sort the sections in the sidebar #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducaale
reviewed
Feb 11, 2024
| import Link from 'next/link' | ||
| import { useRouter } from 'next/router' | ||
| import styled from 'styled-components' | ||
| import { MdDragIndicator } from 'react-icons/md' | ||
| import arrayMove from 'array-move' | ||
| import SortableList, { SortableItem, SortableKnob } from 'react-easy-sort' |
There was a problem hiding this comment.
To avoid the following warning, shall we load SortableList dynamically with ssr disabled?
Warning: useLayoutEffect does nothing on the server, because its effect cannot be encoded into the server renderer's output format. This will lead to a mismatch between the initial, non-hydrated UI and the intended UI. To avoid this, useLayoutEffect should only be used in components that render exclusively on the client. See https://reactjs.org/link/uselayouteffect-ssr for common fixes.
at SortableList (/home/ducaale/resumake.io/node_modules/react-easy-sort/index.js:375:21)
Something like this should do the trick
const SortableList = dynamic(
async () => await import('react-easy-sort'),
{ ssr: false }
)There was a problem hiding this comment.
Not sure, I havent got time to checkout nextjs related things yet. So its your call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.