Skip to content

Commit

Permalink
Make the amp-user-notification URLs in our example files use absolute (
Browse files Browse the repository at this point in the history
…ampproject#4876)

and https paths, since these URLs are not rewritten by the AMP Cache.

See also: ampproject#4537
  • Loading branch information
Gregable authored Sep 8, 2016
1 parent b23b891 commit 49c57f1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions examples/analytics-notification.amp.html
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@
<amp-user-notification
layout=nodisplay
id="amp-user-notification1"
data-show-if-href="/api/show?timestamp=TIMESTAMP"
data-dismiss-href="/api/echo/post">
data-show-if-href="https://example.com/api/show?timestamp=TIMESTAMP"
data-dismiss-href="https://example.com/api/echo/post">
This site uses cookies to personalize content.
<a class="btn" on="tap:amp-user-notification1.dismiss">I accept</a>
</amp-user-notification>
Expand Down
16 changes: 8 additions & 8 deletions examples/user-notification.amp.html
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,8 @@
<amp-user-notification
layout=nodisplay
id="amp-user-notification1"
data-show-if-href="/api/show?timestamp=TIMESTAMP"
data-dismiss-href="/api/echo/post">
data-show-if-href="https://example.com/api/show?timestamp=TIMESTAMP"
data-dismiss-href="https://example.com/api/echo/post">
This site uses cookies to personalize content.
<a href="#learn-more">Learn more.</a>
<button on="tap:amp-user-notification1.dismiss" role="button" tabindex="0">I accept</button>
Expand All @@ -215,8 +215,8 @@
<amp-user-notification
layout=nodisplay
id="amp-user-notification2"
data-show-if-href="/api/dont-show"
data-dismiss-href="/api/echo/post">
data-show-if-href="https://example.com/api/dont-show"
data-dismiss-href="https://example.com/api/echo/post">
notify 2
<a href="#learn-more">Learn more.</a>
<button on="tap:amp-user-notification2.dismiss" role="button" tabindex="1">I accept</button>
Expand All @@ -233,8 +233,8 @@
layout=nodisplay
id="amp-user-notification4"
data-persist-dismissal="false"
data-show-if-href="/api/show?timestamp=TIMESTAMP"
data-dismiss-href="/api/echo/post">
data-show-if-href="https://example.com/api/show?timestamp=TIMESTAMP"
data-dismiss-href="https://example.com/api/echo/post">
This notification should ALWAYS show.
<a href="#learn-more">Learn more.</a>
<button on="tap:amp-user-notification4.dismiss" role="button" tabindex="3">Dismiss</button>
Expand All @@ -244,8 +244,8 @@
layout=nodisplay
id="amp-user-notification5"
data-persist-dismissal="false"
data-show-if-href="/api/dont-show"
data-dismiss-href="/api/echo/post">
data-show-if-href="https://example.com/api/dont-show"
data-dismiss-href="https://example.com/api/echo/post">
This notification should NEVER show.
<a href="#learn-more">Learn more.</a>
<button on="tap:amp-user-notification5.dismiss" role="button" tabindex="4">Dismiss</button>
Expand Down

0 comments on commit 49c57f1

Please sign in to comment.