-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2.0 #964
Merged
Merged
Release v1.2.0 #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: foundry multibuild
* build: update solarray * build: switch to bun for dep management * docs: add more context in contributing guide
ci: bot for closing stale issues and PR
As realized in #748, keeping the Etherscan API keys in version control is not worth the maintenance cost.
ci: use reusable workflows
* build: add deploy multi chains script build: remove etherscan api keys in foundry.toml feat: add deploy core 3 scripts chore: improve .env.example file * build: add arbitrum sepolia chore: git ignore deployments dir * chore: update wording in scripts chore: remove forge fmt comment * refactor: separate base env from deployment env chore: improve multi-chain deployment script refactor: rename env var MAX_SEGMENT_COUNT * refactor: rename multi-chain script * chore: fix arbitrum config key * fix: use array to create deployment command * chore: create an array for deployment command * Powerful command line options for deployment script (#752) * build: add script to generate deployment command * feat: new command-line options for deploy-multi-chain command * chore: continue for warnings and throw for errors * perf: polish deployment script --------- Co-authored-by: Paul Razvan Berg <[email protected]> * refactor: hard code admin addresses --------- Co-authored-by: andreivladbrg <[email protected]> Co-authored-by: smol-ninja <[email protected]>
docs: increase bug bounty
* feat: add a util function to construct the create2 salt build: udpate multi chain script * chore: solhint-disable no-console in Base_Script * docs: improve natspec in constructCreate2Salt chore: remove underscore from function name * test: constructCreate2Salt function * build: set ffi true in test foundry profile
* perf: emit events before hook calls * refactor: remove updateMetadata modifier * test(refactor): reverse order of expected events emitted by transferFrom * test(refactor): reverse order of expected events emitted by transferFrom * refactor: Emit
…Amount (#941) test: test streamedAmountOf when cliff time is zero and the stream is PENDING test: correct tree branches in streamedAmountOf
build: bump deps
* build: add npm ignore file build: exclude *.t.sol files from NPM package * test: absolute paths in precompiles test * build: remove .npmignore build: add "!test/utils/*.t.sol" in package json files * build: npm ignore file in test utils --------- Co-authored-by: Paul Razvan Berg <[email protected]>
* build: bump solc * build: update precompiles --------- Co-authored-by: Paul Razvan Berg <[email protected]>
* refactor: disallow non alphanumeric symbols * feat: allow empty spaces in "isAlphanumeric" refactor: alphabetical ordering refactor: return different string test: thorough concrete tests for "isAlphanumeric" * refactor: simplify logical conditions test: fuzz tests for "isAlphanumeric" test: shared test contract for NFT descriptor --------- Co-authored-by: Paul Razvan Berg <[email protected]>
* test: eip4906 interface * feat: eip4906 interface * doc: eip4906 interface
* refactor: inherit IERC-4906 in interface * refactor: import libraries in alphabetical order --------- Co-authored-by: smol-ninja <[email protected]>
* refactor: rename alphanumeric function * chore: update precompiles --------- Co-authored-by: andreivladbrg <[email protected]>
* refactor: delete sender withdraw hooks refactor: delete renounce hook test: improve test function names test: update renounce and withdraw hook tests * refactor: rename hooks * refactor: get rid of "hooks" directory * feat: add marker "IS_SABLIER_RECIPIENT" refactor: rename "SablierV2Recipient" to "SablierRecipient" * feat: hook allowlist feat: isAllowedToHook feat: allowToHook test: rename recipient hooks mocks * feat: check allowlist when running hooks refactor: remove try/ catch in hooks refactor: rename "_allowed" to "_allowedToHook" test: update cancel and withdraw tests * build: update precompiles * fix: remove stale dir in prepare-artifacts script * docs: update withdraw natspec * chore: address PR feedback * feat: include function selector in the return value of hook calls * fix: redundant dev notes, use interface selector * test: fix bugs * feat: replace IS_SABLIER_RECIPIENT with IERC165-supportsInterface * refactor: remove local import from Errors * docs: polish natspec * refactor: rename recipient interface * refactor: change param type to "address" * build: update precompiles * refactor: remove unneeded address casting * docs: polish natspec * chore: update count map in Base script * chore: update benchmarks * docs: mention allowlist contract in Security doc * docs: update wording --------- Co-authored-by: andreivladbrg <[email protected]> Co-authored-by: smol-ninja <[email protected]>
* test: rename variables * docs: wording improvement
* refactor: index admin in AllowToHook event * feat: include dash in alphanumeric check * build: update precompiles * docs: update natspec * refactor: rename isAlphanumericWithSpaces to IsAllowedCharacter * test: fixes --------- Co-authored-by: Paul Razvan Berg <[email protected]>
…axAndTransfer (#961) * refactor: return the withdrawn amount test: the return value in withdrawMax and withdrawMaxAndTransfer * chore: update precompiles * shub feedback
* docs: roll 1.2.0 * docs: remove solidity mention from changelog * docs: update date * docs: update changelog * docs(license): update BUSL license change date * test: update version in BaseScript Test * docs(refactor): use bump * docs(refactor): use bump in OpenZeppelin * docs(refactor): changelog * docs: update changelog * docs: update date in changelog * docs(changelog): address feedback * change date * docs(changelog): include create rename --------- Co-authored-by: andreivladbrg <[email protected]>
Release v1.2.0
smol-ninja
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming its just main
merging into release
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.