add ncmpcpp pkg #547
add ncmpcpp pkg #547
Conversation
pkg/ncmpcpp
Outdated
| [deps] | ||
| boost | ||
| gnu-readline | ||
| automake |
There was a problem hiding this comment.
automake is a host dep ( [deps.host] pls)
pkg/ncmpcpp
Outdated
| automake | ||
|
|
||
| [deps.run] | ||
| libmpdclient |
There was a problem hiding this comment.
does libmpdclient ship executables that are called at runtime, unlike its name suggests ? if so, this is the right section to put it. but if it is a library, which code is linked against at build time, it should be in [deps]
pkg/ncmpcpp
Outdated
| filesize=219516 | ||
| sha512=8dd78f463811826729cb1498a7ccc4bff49393e88adb80260ad499623cf4ecdce5b405c1d91ca03f0b34bb7f5329124cb7a0541dbb880be2a634b057af93b9aa | ||
| pkgver=1 | ||
| tardir=ncmpcpp-b7da5d1b9af1f3b0022c1f7daa0c7d12ae72a21d |
There was a problem hiding this comment.
please use a tarball directive too, so the tarball doesnt get saved as 324894038024.tar.gz, which nobody can figure out what it actually is
| ADD_ONS="--enable-clock --enable-visualizer" | ||
| # -------------------------------------------------------- | ||
|
|
||
| ./autogen.sh |
There was a problem hiding this comment.
why do you run autogen.sh ? if it's possible, we rahter avoid that, since automake is a very heavy dependency. if it is because there's no configure script in the git checkout, maybe the author has tagged releases which include proper release tarballs with included configure script (related info: https://github.com/sabotage-linux/sabotage/wiki/Why-github-downloads-suck )
There was a problem hiding this comment.
it does not ship with a configure script, and there isn't a "releases" page on his github.
The author has the configure script in his git-ignore. Looking back into commits of years ago you might be able to find a script but at that point its too old anyway.
Let me know what you want to do, and sorry if I misunderstood your comment
There was a problem hiding this comment.
that's how i do it: i raise awareness of the issue ncmpcpp/ncmpcpp#263
is there a specific reason you want to have latest master, over the latest tagged release from 2 weeks ago ? as i already mentioned, releases are usually preferable over bleeding egde master downloads.
There was a problem hiding this comment.
his releases page is here btw https://github.com/arybczak/ncmpcpp/releases
(click on code, then the releases button is visible)
| # NOTE TO USERS: clock and visualizer are enabled by default | ||
| # on most distros, so they are to be expected. If you don't | ||
| # wish to use them, these flags can be deleted: | ||
| ADD_ONS="--enable-clock --enable-visualizer" |
There was a problem hiding this comment.
if you want to make this customizable, maybe you could just check if the environment var is already set, indicating that the user wants it changed, that way he doesnt need to edit the package itself
add ncmpcpp2
|
the author pointed out that he has proper release tarballs available: by using this one http://rybczak.net/ncmpcpp/stable/ncmpcpp-0.8.1.tar.bz2 we dont need the automake dependency |
ncmpcpp a featureful ncurses based MPD client inspired by ncmpc.
Normally distros include the visualizer and clock in their package, and is one of the reasons people like ncmpcpp. So I added them in by default, with a comment block allowing people to edit it out if they don't want it.
Note on gnu-readline dep: it kept complaining about readline RL_TERMINAL_* messages, but after installing gnu-readline these errors went away. Maybe this dep isn't needed and can be patched, but I'm not that experienced with that sort of thing.
Note on libmpdclient dep: This is required to interface with mpd, see my other pull request for this pkg.