Reworked Models and Contollers and added service classes #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryan-Holden
commented
Dec 9, 2024
Ryan-Holden
commented
- Created service classes for User, calendar, and address book controllers.
- Created an Icon helper class to replace static icon functions in each model.
- Updated models and controllers to work with the new service classes.
Added AddressBooks
Redo of AddressBooks
Update address books
|
Hi, thanks for your PR. I must admit I don't really understand what this PR does. Why do we need to move the database calls from the database objects to their own classes? Why do we need a MS Azure deploy action? Why do we need a class that just returns the icons that we use in the UI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.