Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore autoPrefix property of Href #1514

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

phil-davis
Copy link
Contributor

use of this property in code was removed in PR
#801
But the property is left here because old data may still exist that has this property saved.

See discussion in sabre-io/Baikal#1154

Fixes sabre-io/Baikal#1154 and related issue #1445

@phil-davis
Copy link
Contributor Author

If this is the accepted fix, then I will backport it to 4.5 and make a 4.5.1 release.

use of this property in code was removed in PR
sabre-io#801
But the property is left here because old data may still exist
that has this property saved.

See discussion in sabre-io/Baikal#1154
@DeepDiver1975
Copy link
Member

Was is always protected? I don't know right now if unserialize has issues with property access.....

@phil-davis
Copy link
Contributor Author

Was is always protected? I don't know right now if unserialize has issues with property access.....

I copied from what was deleted in:
https://github.com/sabre-io/dav/pull/801/files#diff-abad1406d5405d56e66aa47e67d2277a2707befef8d570f871a2c243676729b0

@DeepDiver1975
Copy link
Member

just looked it up - serialize/unserialize require the access level to be unchanged.
Since this is the case I think we can safely merge this.

@DeepDiver1975 DeepDiver1975 merged commit b397796 into sabre-io:master Nov 22, 2023
7 checks passed
@phil-davis phil-davis deleted the baikal-1154 branch November 23, 2023 04:18
@phil-davis
Copy link
Contributor Author

Backported to 4.5 branch in PR #1515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.2 dynamic properties deprecation warnings
2 participants