Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAV\PropPatch::handleRemaining should only register one callback #1553

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

paulmhh
Copy link

@paulmhh paulmhh commented Jul 5, 2024

currently handleRemaining() will create one callback for each remaining property update but with the whole array of remaining properties as parameter. Thus doCallBackMultiProp() is being used (in each callback! It should be either one callback with an array as parameter, or it should multiple callbacks with a string as parameter)

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.24%. Comparing base (c327c0f) to head (937322c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1553   +/-   ##
=========================================
  Coverage     97.24%   97.24%           
  Complexity     2834     2834           
=========================================
  Files           175      175           
  Lines          8843     8843           
=========================================
  Hits           8599     8599           
  Misses          244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to have a unit test for this - thx

@paulmhh paulmhh force-pushed the master branch 2 times, most recently from df9f086 to 842df42 Compare September 6, 2024 14:03
@paulmhh
Copy link
Author

paulmhh commented Sep 6, 2024

sorry for the force pushes, had some trouble to run the github workflow and then the cs-fixer wanted some minor change and I had to iterate.

I did test the test without my fix. It fails. With the fix applied it is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants