Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.4 deprecations #1560

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix PHP 8.4 deprecations #1560

merged 2 commits into from
Sep 5, 2024

Conversation

cedric-anne
Copy link
Contributor

Backport of #1556, but for the 4.6 branch.

@cedric-anne
Copy link
Contributor Author

I tried to update CS rules, but it is not possible to use the corresponding rules on PHPCS-Fixer 2.x and not possible to install the 3.x version on this branch because it is not compatible with PHP 7.1 -> 7.3.

@DeepDiver1975 DeepDiver1975 merged commit 986d5f3 into sabre-io:4.6 Sep 5, 2024
11 checks passed
@cedric-anne cedric-anne deleted the 4.6/php-8.4 branch September 5, 2024 09:51
@nickvergessen
Copy link
Contributor

Would be cool to release this to reduce the noise, any plans to do so?

@phil-davis
Copy link
Contributor

Released in https://github.com/sabre-io/dav/releases/tag/4.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants