Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return type of XmlFragment::xmlDeserialize to match base declara… #258

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

DeepDiver1975
Copy link
Member

…tion

XmlDeserializable::xmlDeserialize has no return type defined as well and any sub-class of XmlFragment will also return mixed - see various xml classes in sabre/dav

refs

public static function xmlDeserialize(Reader $reader);

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #258 (f273a8c) into master (a0de970) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #258   +/-   ##
=========================================
  Coverage     96.75%   96.75%           
  Complexity      115      115           
=========================================
  Files            13       13           
  Lines           493      493           
=========================================
  Hits            477      477           
  Misses           16       16           
Files Coverage Δ
lib/Element/XmlFragment.php 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@DeepDiver1975 DeepDiver1975 merged commit b53d594 into master Nov 9, 2023
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/xmlfragment-deserialize-return branch November 9, 2023 09:41
@phil-davis phil-davis mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants