Support sorting by dates #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why** is the change needed?
That's very fundamental to how I use Todoist since I assign each task
with a timestamp and rely on them appearing ordered by date.
**How** is the need addressed?
- Replace `--priority` flag with `--sort (date|priority)` for better
extensibility
- Label the `--priority` flag as deprecated
What **side-effects** could the change have?
- Clutters the code base until the `--priority` flag can be removed.
Still better than breaking changes. Can be removed after a reasonable
migration time.
psethwick
reviewed
Aug 2, 2023
| @@ -21,6 +21,9 @@ func traverseItems(item *todoist.Item, f func(item *todoist.Item, depth int), de | |||
| } | |||
| } | |||
|
|
|||
| var byPriority int = 1 | |||
There was a problem hiding this comment.
these could be iota instead of manually numbered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is the change needed?
That's very fundamental to how I use Todoist since I assign each task
with a timestamp and rely on them appearing ordered by date.
How is the need addressed?
--priorityflag with--sort (date|priority)for betterextensibility
--priorityflag as deprecatedWhat side-effects could the change have?
--priorityflag can be removed.Still better than breaking changes. Can be removed after a reasonable
migration time.