HDDS-9927. Ozone List keys CLI should co-ordinate between max limit a…

…nd listCacheSize.
sadanand48 · Jan 3, 2024 · 8f42936 · 8f42936
1 parent b9e74f6
commit 8f42936
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java b/hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java
@@ -301,6 +301,10 @@ public String getOwner() {
     return owner;
   }
 
+  public int getListCacheSize() {
+    return listCacheSize;
+  }
+
   /**
    * Builder for OmBucketInfo.
   /**
@@ -405,6 +409,10 @@ public void setReplicationConfig(ReplicationConfig replicationConfig)
     proxy.setReplicationConfig(volumeName, name, replicationConfig);
   }
 
+  public void setListCacheSize(int listCacheSize) {
+    this.listCacheSize = listCacheSize;
+  }
+
   /**
    * Creates a new key in the bucket, with default replication type RATIS and
    * with replication factor THREE.

diff --git a/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/ListKeyHandler.java b/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/keys/ListKeyHandler.java
@@ -77,10 +77,13 @@ private void listKeysInsideBucket(OzoneClient client, OzoneAddress address)
 
     OzoneVolume vol = client.getObjectStore().getVolume(volumeName);
     OzoneBucket bucket = vol.getBucket(bucketName);
+    int maxKeyLimit = listOptions.getLimit();
+    if (maxKeyLimit < bucket.getListCacheSize()) {
+      bucket.setListCacheSize(maxKeyLimit);
+    }
     Iterator<? extends OzoneKey> keyIterator = bucket.listKeys(
         keyPrefix, listOptions.getStartItem());
 
-    int maxKeyLimit = listOptions.getLimit();
     int counter = printAsJsonArray(keyIterator, maxKeyLimit);
 
     // More keys were returned notify about max length