Skip to content

Commit

Permalink
Update warning message
Browse files Browse the repository at this point in the history
  • Loading branch information
germartinez committed Aug 2, 2022
1 parent 7c27fa4 commit 46fb375
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/safe-core-sdk/scripts/postinstall.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
function postInstall() {
console.warn(
'WARNING! "signTransaction" method now *returns* the signed Safe transaction. Update your code according to the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction. In >=v3.0.0 the signature will only be added to the returned object, not the one that is passed as params.'
`⚠️ the "signTransaction" method now returns a signed Safe transaction. Please update your code according to the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction. In >=v3.0.0, the signature will be added only to the return transaction object, and not to the one passed as an argument.`
)
}

Expand Down
2 changes: 1 addition & 1 deletion packages/safe-core-sdk/src/Safe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ class Safe {

// TO-DO: Remove in v3.0.0 {
console.warn(
'WARNING! "signTransaction" method now *returns* the signed Safe transaction. Update your code according to the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction. In >=v3.0.0 the signature will only be added to the returned object, not the one that is passed as params.'
`⚠️ the "signTransaction" method now returns a signed Safe transaction. Please update your code according to the new documentation: https://github.com/safe-global/safe-core-sdk/tree/main/packages/safe-core-sdk#signtransaction. In >=v3.0.0, the signature will be added only to the return transaction object, and not to the one passed as an argument.`
)
safeTransaction.addSignature(signature)
// }
Expand Down

0 comments on commit 46fb375

Please sign in to comment.