Optimise Docker image #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Docker file now uses a multistage build setup which is split into two different stages: * `builder` stage * final/production stage - The `builder` stage uses the `requirements.txt` to download and install the required dependencies for the project. * This stage needs `gcc` and `libpq-dev` to build the dependencies of the project * This stage removed the following dependencies: `build-essential`, `git`, `libssl-dev` as they are not required. - The final/production stage uses the dependencies that were built in the `builder` stage by copying those to the respective local folders of the new final image. * This stage copies all the contents of the project into the `/app` folder. * Additionally, it also installs `libpq-dev` as this is a required runtime dependency. Other considerations: - The setting `PYTHONDONTWRITEBYTECODE` was considered. This would tell Python to not create `pyc` files which would save around 6MB. However, in a multiprocess container (with Gunicorn), each process might need to incur on generating that bytecode again. Using more storage in this case seems therefore, more appropriate.
Pull Request Test Coverage Report for Build 9567035724Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builderstagebuilderstage uses therequirements.txtto download and install the required dependencies for the project.gccandlibpq-devto build the dependencies of the projectbuild-essential,git,libssl-devas they are not required.builderstage by copying those to the respective local folders of the new final image./appfolder.libpq-devas this is a required runtime dependency.Other considerations:
PYTHONDONTWRITEBYTECODEwas considered. This would tell Python to not createpycfiles which would save around 6MB. However, in a multiprocess container (with Gunicorn), each process might need to incur on generating that bytecode again. Using more storage in this case seems therefore, more appropriate.