Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tx-builder): fix contract method filtering #816

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(tx-builder): fix contract method filtering #816

merged 1 commit into from
Aug 28, 2024

Conversation

lmy375
Copy link
Contributor

@lmy375 lmy375 commented Aug 28, 2024

Resolves #815

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

I have read the CLA Document and I hereby sign the CLA

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

recheck

2 similar comments
@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

recheck

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

recheck

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

I have read the CLA Document and I hereby sign the CLA

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

recheck

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

I have read the CLA Document and I hereby sign the CLA

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

recheckcla

@lmy375 lmy375 closed this Aug 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@katspaugh katspaugh reopened this Aug 28, 2024
@safe-global safe-global unlocked this conversation Aug 28, 2024
katspaugh
katspaugh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, thank you! Have you tested it?

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

I have read the CLA Document and I hereby sign the CLA

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

Actually not 😢 But the patch is so simple that I believe we can skip the test?

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

By the way I've no idea why I can not sign the CLA by comment. I'll try with another PR. This will be closed.

@lmy375 lmy375 closed this Aug 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
@katspaugh katspaugh reopened this Aug 28, 2024
@safe-global safe-global unlocked this conversation Aug 28, 2024
@katspaugh
Copy link
Member

Please don't close it again. One PR is enough. The CLA check is fine.

@lmy375
Copy link
Contributor Author

lmy375 commented Aug 28, 2024

OK. Seems to be an issue caused by multiple git accounts. Should be fine now.

@katspaugh
Copy link
Member

Thanks!

@katspaugh katspaugh merged commit 9cbefc5 into safe-global:development Aug 28, 2024
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tx-builder: ABI items of error type should not be considered as methods.
2 participants
@lmy375 @katspaugh