Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tx-builder-theme): move safe react components to TX-builder components folder #822

Conversation

clovisdasilvaneto
Copy link
Contributor

Current we're using an outdated theme in the transaction builder application. In order to have the right theme introduced on it, we need to first adjust the internal theme structure which we use in our components, and since the https://github.com/5afe/safe-react-components repo is achieved me and @katspaugh decided to move the components to the tx-builder/components folder and change the internal theme structure that the components are using.

What it solves

Resolves #820

How this PR fixes it

It moves the components from the safe-react-components repo to the tx-builder/components folder and introduce the right Safe theme into the application

How to test it

  • All unit tests from the tx-builder folder shuold pass. Currently we're not using it yet A follow-up PR will be send after this one is merged

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@clovisdasilvaneto clovisdasilvaneto changed the title Chore/move react components to tx builder chore(tx-builder-theme): react components to tx builder Sep 25, 2024
@clovisdasilvaneto clovisdasilvaneto changed the title chore(tx-builder-theme): react components to tx builder chore(tx-builder-theme): use new tx-builder components Sep 25, 2024
@clovisdasilvaneto clovisdasilvaneto changed the title chore(tx-builder-theme): use new tx-builder components chore(tx-builder-theme): remove safe react components #823 Sep 25, 2024
@clovisdasilvaneto clovisdasilvaneto changed the title chore(tx-builder-theme): remove safe react components #823 chore(tx-builder-theme): move safe react components to TX-builder components folder Sep 25, 2024
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@clovisdasilvaneto clovisdasilvaneto force-pushed the chore/move-react-components-to-tx-builder branch from 248e46b to f0a67ea Compare September 27, 2024 10:51
@clovisdasilvaneto
Copy link
Contributor Author

@francovenica I'll came up with another PR then 👍

@clovisdasilvaneto clovisdasilvaneto merged commit 8f5c550 into chore/normalize-tx-builder-theme Oct 4, 2024
4 of 7 checks passed
@clovisdasilvaneto clovisdasilvaneto deleted the chore/move-react-components-to-tx-builder branch October 4, 2024 07:59
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants