-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tx-builder-theme): Remove safe-react components and theme from the tx-builder application #823
chore(tx-builder-theme): Remove safe-react components and theme from the tx-builder application #823
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
"@safe-global/safe-gateway-typescript-sdk@^3.19.0": | ||
version "3.22.2" | ||
resolved "https://registry.yarnpkg.com/@safe-global/safe-gateway-typescript-sdk/-/safe-gateway-typescript-sdk-3.22.2.tgz#d4ff9972e58f9344fc95f8d41b2ec6517baa8e79" | ||
integrity sha512-Y0yAxRaB98LFp2Dm+ACZqBSdAmI3FlpH/LjxOZ94g/ouuDJecSq0iR26XZ5QDuEL8Rf+L4jBJaoDC08CD0KkJw== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that this appeared. Is it due to yarn install
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
95506c1
to
74ebd9e
Compare
248e46b
to
f0a67ea
Compare
74ebd9e
to
0bd768f
Compare
…stead the safe-react-components n
0bd768f
to
e8c8eaa
Compare
…g to mui style guide
Hi @francovenica, yes the form width is not part of the change, however I think I can make it looks a bit better. |
Ok, the ticket how it is can be passed to "ready to merge". Let me know if you can try that change you suggested here or if you will create a new PR for it. Thanks |
e18e89a
into
chore/normalize-tx-builder-theme
Current we're using an outdated theme in the transaction builder application. In order to have the right theme introduced on it, we need to first adjust the internal theme structure which we use in our components, and since the https://github.com/5afe/safe-react-components repo is achieved me and @katspaugh decided to move the components to the tx-builder/components folder and change the internal theme structure that the components are using.
What it solves
Resolves #820
How this PR fixes it
It uses the moved safe-react-components in the tx-builder screens
How to test it