Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Safe.sol with ECDSA malleability warning #877

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Enhance Safe.sol with ECDSA malleability warning #877

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b6ccb4
Enhance Safe.sol with ECDSA malleability warning
mmv08 Jan 2, 2025
7b49e1e
Merge branch 'main' into sig-malleability-comments
mmv08 Jan 9, 2025
21d1302
Merge branch 'main' into sig-malleability-comments
mmv08 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/Safe.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,10 @@ contract Safe is
address currentOwner;
uint256 v; // Implicit conversion from uint8 to uint256 will be done for v received from signatureSplit(...).
bytes32 r;
// NOTE: We do not enforce the `s` to be from the lower half of the curve
// This essentially means that for every signature, there's another valid signature (known as ECDSA malleability)
// Since we have other mechanisms to prevent duplicated signatures (ordered owners array) and replay protection (nonce),
// we can safely ignore this malleability.
bytes32 s;
uint256 i;
for (i = 0; i < requiredSignatures; i++) {
Expand Down
Loading