Update deprecated firebase function (#2231)

* Update deprecated firebase function * Mock right function
safe-global · Sep 27, 2024 · a5c3cac · a5c3cac
1 parent fc8e7e6
commit a5c3cac
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/safe_transaction_service/notifications/clients/firebase_client.py b/safe_transaction_service/notifications/clients/firebase_client.py
@@ -159,7 +159,9 @@ def send_message(
             data=data,
             tokens=tokens,
         )
-        batch_response: BatchResponse = messaging.send_multicast(message, app=self.app)
+        batch_response: BatchResponse = messaging.send_each_for_multicast(
+            message, app=self.app
+        )
         responses: List[SendResponse] = batch_response.responses
         # Check if there are invalid tokens
         invalid_tokens = [

diff --git a/safe_transaction_service/notifications/tasks.py b/safe_transaction_service/notifications/tasks.py
@@ -112,6 +112,8 @@ def send_notification_task(
         success_count, failure_count, invalid_tokens = firebase_client.send_message(
             tokens, payload
         )
+        if failure_count:
+            logger.error("Push notification failed for %i devices", failure_count)
         if invalid_tokens:
             logger.info(
                 "Removing invalid tokens for safe=%s. Tokens=%s",

diff --git a/safe_transaction_service/notifications/tests/test_firebase_client.py b/safe_transaction_service/notifications/tests/test_firebase_client.py
@@ -48,7 +48,7 @@ def test_firebase_client(self, initialize_app_mock):
                     ]
                     batch_response = BatchResponse(responses)
                     with mock.patch(
-                        "firebase_admin.messaging.send_multicast",
+                        "firebase_admin.messaging.send_each_for_multicast",
                         return_value=batch_response,
                     ):
                         (

diff --git a/scripts/firebase_test.py b/scripts/firebase_test.py