chore: update eslint to v9

safe-global · Nov 6, 2024 · 056618b · 056618b
1 parent 272f506
commit 056618b
Show file tree

Hide file tree

Showing 40 changed files with 384 additions and 341 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -0,0 +1,77 @@
+import unusedImports from 'eslint-plugin-unused-imports'
+import typescriptEslint from '@typescript-eslint/eslint-plugin'
+import noOnlyTests from 'eslint-plugin-no-only-tests'
+import tsParser from '@typescript-eslint/parser'
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+import js from '@eslint/js'
+import { FlatCompat } from '@eslint/eslintrc'
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = path.dirname(__filename)
+const compat = new FlatCompat({
+  baseDirectory: __dirname,
+  recommendedConfig: js.configs.recommended,
+  allConfig: js.configs.all,
+})
+
+export default [
+  {
+    ignores: ['**/node_modules/', '**/.next/', '**/.github/', '**/cypress/', 'src/types/contracts/'],
+  },
+  ...compat.extends('next', 'prettier', 'plugin:prettier/recommended', 'plugin:storybook/recommended'),
+  {
+    plugins: {
+      'unused-imports': unusedImports,
+      '@typescript-eslint': typescriptEslint,
+      'no-only-tests': noOnlyTests,
+    },
+
+    languageOptions: {
+      parser: tsParser,
+      ecmaVersion: 5,
+      sourceType: 'script',
+
+      parserOptions: {
+        project: ['./tsconfig.json'],
+      },
+    },
+
+    rules: {
+      '@next/next/no-img-element': 'off',
+      '@next/next/google-font-display': 'off',
+      '@next/next/google-font-preconnect': 'off',
+      '@next/next/no-page-custom-font': 'off',
+      'unused-imports/no-unused-imports': 'error',
+      '@typescript-eslint/consistent-type-imports': 'error',
+      '@typescript-eslint/await-thenable': 'error',
+      'no-constant-condition': 'warn',
+
+      'unused-imports/no-unused-vars': [
+        'error',
+        {
+          varsIgnorePattern: '^_',
+        },
+      ],
+
+      'react-hooks/exhaustive-deps': [
+        'warn',
+        {
+          additionalHooks: 'useAsync',
+        },
+      ],
+
+      'no-only-tests/no-only-tests': 'error',
+      'object-shorthand': ['error', 'properties'],
+      'jsx-quotes': ['error', 'prefer-double'],
+
+      'react/jsx-curly-brace-presence': [
+        'error',
+        {
+          props: 'never',
+          children: 'never',
+        },
+      ],
+    },
+  },
+]
diff --git a/package.json b/package.json
@@ -100,6 +100,8 @@
   "devDependencies": {
     "@chromatic-com/storybook": "^1.3.1",
     "@cowprotocol/app-data": "^2.1.0",
+    "@eslint/eslintrc": "^3.1.0",
+    "@eslint/js": "^9.14.0",
     "@faker-js/faker": "^9.0.3",
     "@mdx-js/loader": "^3.0.1",
     "@mdx-js/react": "^3.0.1",
@@ -140,20 +142,20 @@
     "cypress": "^12.15.0",
     "cypress-file-upload": "^5.0.8",
     "cypress-visual-regression": "^5.0.2",
-    "eslint": "^8.57.0",
-    "eslint-config-next": "15.0.2",
-    "eslint-config-prettier": "^8.5.0",
-    "eslint-plugin-no-only-tests": "^3.1.0",
-    "eslint-plugin-prettier": "^4.0.0",
-    "eslint-plugin-storybook": "^0.8.0",
-    "eslint-plugin-unused-imports": "^2.0.0",
+    "eslint": "^9.14.0",
+    "eslint-config-next": "^15.0.2",
+    "eslint-config-prettier": "^9.1.0",
+    "eslint-plugin-no-only-tests": "^3.3.0",
+    "eslint-plugin-prettier": "^5.2.1",
+    "eslint-plugin-storybook": "^0.11.0",
+    "eslint-plugin-unused-imports": "^4.1.4",
     "fake-indexeddb": "^4.0.2",
     "gray-matter": "^4.0.3",
     "husky": "^9.0.11",
     "jest": "^29.6.2",
     "jest-environment-jsdom": "^29.6.2",
     "mockdate": "^3.0.5",
-    "prettier": "^2.7.0",
+    "prettier": "^3.3.3",
     "remark-frontmatter": "^5.0.0",
     "remark-gfm": "^4.0.0",
     "remark-heading-id": "^1.0.1",

diff --git a/src/components/common/SafeTokenWidget/__tests__/SafeTokenWidget.test.tsx b/src/components/common/SafeTokenWidget/__tests__/SafeTokenWidget.test.tsx
@@ -20,7 +20,7 @@ describe('SafeTokenWidget', () => {
       () =>
         ({
           get: () => fakeSafeAddress,
-        } as any),
+        }) as any,
     )
 
     jest.spyOn(safePass, 'useGetOwnGlobalCampaignRankQuery').mockReturnValue({

diff --git a/src/components/new-safe/create/steps/AdvancedOptionsStep/index.tsx b/src/components/new-safe/create/steps/AdvancedOptionsStep/index.tsx
@@ -160,7 +160,7 @@ const AdvancedOptionsStep = ({ onSubmit, onBack, data, setStep }: StepRenderProp
               label="Salt nonce"
               error={Boolean(formState.errors[AdvancedOptionsFields.saltNonce]) || Boolean(isDeployed)}
               helperText={
-                formState.errors[AdvancedOptionsFields.saltNonce]?.message ?? Boolean(isDeployed)
+                (formState.errors[AdvancedOptionsFields.saltNonce]?.message ?? Boolean(isDeployed))
                   ? 'The Safe is already deployed. Use a different salt nonce.'
                   : undefined
               }

diff --git a/src/components/settings/FallbackHandler/__tests__/index.test.tsx b/src/components/settings/FallbackHandler/__tests__/index.test.tsx
@@ -34,7 +34,7 @@ describe('FallbackHandler', () => {
               name: 'FallbackHandlerName',
             },
           },
-        } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+        }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
     )
 
     const fbHandler = render(<FallbackHandler />, {
@@ -71,7 +71,7 @@ describe('FallbackHandler', () => {
               name: 'FallbackHandlerName',
             },
           },
-        } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+        }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
     )
 
     const fbHandler = render(<FallbackHandler />, {
@@ -104,7 +104,7 @@ describe('FallbackHandler', () => {
               value: GOERLI_FALLBACK_HANDLER,
             },
           },
-        } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+        }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
     )
 
     const fbHandler = render(<FallbackHandler />, {
@@ -125,7 +125,7 @@ describe('FallbackHandler', () => {
               version: '1.3.0',
               chainId: '5',
             },
-          } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+          }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
       )
 
       const fbHandler = render(<FallbackHandler />)
@@ -150,7 +150,7 @@ describe('FallbackHandler', () => {
               version: '1.3.0',
               chainId: '5',
             },
-          } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+          }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
       )
 
       const fbHandler = render(<FallbackHandler />)
@@ -178,7 +178,7 @@ describe('FallbackHandler', () => {
                 value: '0x123',
               },
             },
-          } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+          }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
       )
 
       const fbHandler = render(<FallbackHandler />)
@@ -212,7 +212,7 @@ describe('FallbackHandler', () => {
                 value: '0x123',
               },
             },
-          } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+          }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
       )
 
       const fbHandler = render(<FallbackHandler />)
@@ -232,7 +232,7 @@ describe('FallbackHandler', () => {
             version: '1.0.0',
             chainId: '5',
           },
-        } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+        }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
     )
 
     const fbHandler = render(<FallbackHandler />)
@@ -251,7 +251,7 @@ describe('FallbackHandler', () => {
               value: TWAP_FALLBACK_HANDLER,
             },
           },
-        } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+        }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
     )
 
     const { getByText } = render(<FallbackHandler />)
@@ -274,7 +274,7 @@ describe('FallbackHandler', () => {
               value: TWAP_FALLBACK_HANDLER,
             },
           },
-        } as unknown as ReturnType<typeof useSafeInfoHook.default>),
+        }) as unknown as ReturnType<typeof useSafeInfoHook.default>,
     )
 
     const { queryByText } = render(<FallbackHandler />)

diff --git a/...omponents/settings/PushNotifications/hooks/__tests__/useNotificationRegistrations.test.ts b/...omponents/settings/PushNotifications/hooks/__tests__/useNotificationRegistrations.test.ts
@@ -35,7 +35,7 @@ describe('useNotificationRegistrations', () => {
         () =>
           ({
             label: 'MetaMask',
-          } as ConnectedWallet),
+          }) as ConnectedWallet,
       )
     })
 
@@ -75,7 +75,7 @@ describe('useNotificationRegistrations', () => {
         () =>
           ({
             uuid: undefined,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -105,7 +105,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid: self.crypto.randomUUID(),
             createPreferences: createPreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -137,7 +137,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid: self.crypto.randomUUID(),
             createPreferences: createPreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -168,7 +168,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid: self.crypto.randomUUID(),
             createPreferences: createPreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const showNotificationSpy = jest.spyOn(notificationsSlice, 'showNotification')
@@ -197,7 +197,7 @@ describe('useNotificationRegistrations', () => {
         () =>
           ({
             uuid: undefined,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -219,7 +219,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid,
             deletePreferences: deletePreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -245,7 +245,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid,
             deletePreferences: deletePreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -271,7 +271,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid,
             deletePreferences: deletePreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -295,7 +295,7 @@ describe('useNotificationRegistrations', () => {
         () =>
           ({
             uuid: undefined,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -317,7 +317,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid,
             deleteAllChainPreferences: deleteAllChainPreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -340,7 +340,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid,
             deleteAllChainPreferences: deleteAllChainPreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())
@@ -363,7 +363,7 @@ describe('useNotificationRegistrations', () => {
           ({
             uuid,
             deleteAllChainPreferences: deleteAllChainPreferencesMock,
-          } as unknown as ReturnType<typeof preferences.useNotificationPreferences>),
+          }) as unknown as ReturnType<typeof preferences.useNotificationPreferences>,
       )
 
       const { result } = renderHook(() => useNotificationRegistrations())

diff --git a/src/components/transactions/TxDetails/TxData/Transfer/TransferActions.tsx b/src/components/transactions/TxDetails/TxData/Transfer/TransferActions.tsx
@@ -68,8 +68,8 @@ const TransferActions = ({
   const amount = isNativeTokenTransfer(txInfo.transferInfo)
     ? safeFormatUnits(txInfo.transferInfo.value, ETHER)
     : isERC20Transfer(txInfo.transferInfo)
-    ? safeFormatUnits(txInfo.transferInfo.value, txInfo.transferInfo.decimals)
-    : undefined
+      ? safeFormatUnits(txInfo.transferInfo.value, txInfo.transferInfo.decimals)
+      : undefined
 
   const isOutgoingTx = isOutgoingTransfer(txInfo)
   const canSendAgain =