Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.13.0 #2142

Merged
merged 21 commits into from
Jun 22, 2023
Merged

Release 1.13.0 #2142

merged 21 commits into from
Jun 22, 2023

Conversation

katspaugh
Copy link
Member

v1.13.0

New features

Bug fixes

plusminushalf and others added 18 commits June 8, 2023 10:38
…2075)

* Remember the state of Execute transaction checkbox in settings

* fix typo
)

Bumps [@openzeppelin/contracts](https://github.com/OpenZeppelin/openzeppelin-contracts) from 4.8.3 to 4.9.1.
- [Release notes](https://github.com/OpenZeppelin/openzeppelin-contracts/releases)
- [Changelog](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v4.9.1/CHANGELOG.md)
- [Commits](OpenZeppelin/openzeppelin-contracts@v4.8.3...v4.9.1)

---
updated-dependencies:
- dependency-name: "@openzeppelin/contracts"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Chore: fix e2e tests

* Restore wallet check

* Use prod CGW

* Use prod CGW

* Pending actions

* Create tx
* chore: upgrade onboard

* fix: logo, remove TODO + error expection

* fix: update packages + logo dimensions

* fix: Ledger connection + remove workaround

---------

Co-authored-by: katspaugh <[email protected]>
)

Bumps [@openzeppelin/contracts](https://github.com/OpenZeppelin/openzeppelin-contracts) from 4.9.1 to 4.9.2.
- [Release notes](https://github.com/OpenZeppelin/openzeppelin-contracts/releases)
- [Changelog](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v4.9.2/CHANGELOG.md)
- [Commits](OpenZeppelin/openzeppelin-contracts@v4.9.1...v4.9.2)

---
updated-dependencies:
- dependency-name: "@openzeppelin/contracts"
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: upgrade onboard

* fix: logo, remove TODO + error expection

* fix: update packages + logo dimensions

* feat: add WalletConnect v2 wallet module

* fix: invert wallet labels

* fix: required chains + filter invalid addresses

* fix: revert filtering of empty addresses

* fix: use only current chain as requiredChain

* fix: alter argument name

* fix: patch `@web3-onboard/walletconnect` payload

* fix: regen `yarn.lock`

---------

Co-authored-by: katspaugh <[email protected]>
Co-authored-by: schmanu <[email protected]>
* feat: (WIP) transaction security scanner / warnings

Small scanner interface for transactions with two example implementations
- RuleBasedTransactionScanner
- RedefineTransactionScanner

* fix: add preValidatedSignature to payload

* fix: use messages instead of transactions to avoid missing signatures

* refactor: split ApprovalEditor into editor and approval module

* refactor: add Interface and remove unnecessary code

* refactor: module structure

* feat: add 1st iteration of redefine module

* feat: add severity warning

* fix: clarify types

* feat: transaction security warning components

* Revert "feat: transaction security warning components"

This reverts commit 262af6a.

* feat: transaction security warning components (#1992)

* fix: migrate callbacks to promises + add demo

* feat: decode ERC-20, ERC-721, MultiSend recipients

* feat: expected balance changes

* refactor: remove records instead of map functions, change redefine response type

* refactor: remove service, use proxy, test for useRedefine hook

* feat: recipient address security module (#2030)

* feat: recipient address security module

* fix: description

* fix: delete unused module

* fix: test

* fix: cleanup tests

* fix: adjust payload

* feat: unexpected delegate call security module (#2033)

* [Risk mitigation] Rework components that display security results (#2048)

- uses redefine to scan transactions
- feature toggle to enable it per chain
- analytics
- error handling
- design for the current tx modal

* test: risk mitigation test cases in SignOrExecuteForm.test.tsx

* fix: update redefine simulation URL

* fix: align chip to the right, fix logo in dark mode

* Update balance change list ui

* fix: Spacing and don't show error if there are risk results

* fix: Typo and refactor isSmartContract usage

* Update read more text

* Address feedback

* Fix pluralized label

---------

Co-authored-by: iamacook <[email protected]>
Co-authored-by: Usame Algan <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Branch preview

✅ Deploy successful!

https://release_1_13_0--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jun 21, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

francovenica commented Jun 22, 2023

Only 1 small UI issue with the list of token/NFT's in the "Balance change" block.
To see this send the NFT's of this safe: 0x8675B754342754A30A2AeF474D114d8460bca19b (use impersonator to start the tx, that is enough to see the list)
image

The rest is fine. I've checked the tickets are fine as we checked in their PR's (We already discussed how WC v2 right now is not readable for MM phone app and is kinda wonky with ledger)
The regression was done shorter than usual since we had a release recently already. Still checked the main flows:
Tx creation/addition, owner edition, send funds, Tx builder, spending limits, address book, a few Dapps...

Looks good to me

@katspaugh katspaugh merged commit 11e8906 into main Jun 22, 2023
@katspaugh katspaugh deleted the release/1.13.0 branch June 22, 2023 07:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants