Fix: hide Edit for safeTxGas when 0 in 1.3.0+ #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! |
katspaugh
commented
Jun 23, 2023
| )} | ||
|
|
||
| {editing && <Form onSubmit={() => setEditing(false)} />} |
There was a problem hiding this comment.
Moving the form into a separate component fixes the bug that the default value wasn't updated when safeTxGas is recalculated.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
reviewed
Jun 23, 2023
| </Paper> | ||
| return ( | ||
| <Box display="flex" alignItems="center" gap={1} position="relative"> | ||
| {safeTxGas} |
There was a problem hiding this comment.
I also just realized that we need to adjust the prio of finalSafeTxGas in the provider in case a safe app sends it it should take prio over the recommended value. Right now all Safe App txs send safeTxGas regardless of safe version but we display 0.
usame-algan
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take on #2140
The safeTxGas Edit button will be shown only of safeTxGas is > 0 or it's a Safe below v1.3.0.
Also added baseGas and refundReceiver.
1.1.1 Safe:
